Mono toolchain workload #51327
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,9 @@ | |
| <Import Project="..\Directory.Build.props" /> | ||
| <Import Project="$(NuGetPackageRoot)\microsoft.dotnet.build.tasks.packaging\$(MicrosoftDotNetBuildTasksPackagingVersion)\build\Microsoft.DotNet.Build.Tasks.Packaging.props" /> | ||
|
|
||
| <PropertyGroup> | ||
| <WorkloadTasksAssemblyPath>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'WorkloadBuildTasks', 'Debug', '$(NetCoreAppToolCurrent)'))WorkloadBuildTasks.dll</WorkloadTasksAssemblyPath> | ||
|
Member
Author
There was a problem hiding this comment. @akoeplinger Do you recall why it's always debug?
Member
There was a problem hiding this comment. We always build all tasks in debug. I believe the reason for that was that one of the subsets modified the configuration property which caused the tasks to not build correctly in mixed configurations. Also hardcoding to one configuration avoids a rebuild when you switch configurations when building the repo.
Member
There was a problem hiding this comment. Use NormalizePath instead. NormalizeDirectory is intended to be used for paths to directories where-as NormalizePath is for file paths. |
||
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <PackageIndexFile>$(MSBuildThisFileDirectory)packageIndex.json</PackageIndexFile> | ||
| <PackagePlatform>AnyCPU</PackagePlatform> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| <Project> | ||
| <UsingTask TaskName="GenerateFileFromTemplate" AssemblyFile="$(WorkloadTasksAssemblyPath)" /> | ||
| <Import Project="..\Directory.Build.targets" /> | ||
| <Import Project="$(NuGetPackageRoot)\microsoft.dotnet.build.tasks.packaging\$(MicrosoftDotNetBuildTasksPackagingVersion)\build\Microsoft.DotNet.Build.Tasks.Packaging.targets" /> | ||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <Project DefaultTargets="Build"> | ||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.props))" /> | ||
|
|
||
| <PropertyGroup> | ||
| <PackageDescription>Internal toolchain package not meant for direct consumption. Please do not reference directly.</PackageDescription> | ||
|
Member
There was a problem hiding this comment. Consider setting runtime/Directory.Build.targets Line 54 in cd271c1 |
||
| </PropertyGroup> | ||
|
|
||
| <Target Name="_PrepareForPack" BeforeTargets="GetPackageFiles" Returns="@(PackageFile)"> | ||
| <PropertyGroup> | ||
| <WorkloadManifestPath>$(IntermediateOutputPath)WorkloadManifest.json</WorkloadManifestPath> | ||
| <PackagePathVersion>PackageVersion=$(PackageVersion);</PackagePathVersion> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <_WorkloadManifestValues Include="PackageVersion" Value="$(PackageVersion)" /> | ||
| <_WorkloadManifestValues Include="EmscriptenVersion" Value="$(MicrosoftNETRuntimeEmscriptenVersion)" /> | ||
| </ItemGroup> | ||
|
|
||
| <GenerateFileFromTemplate | ||
| TemplateFile="WorkloadManifest.json.in" | ||
| Properties="@(_WorkloadManifestValues)" | ||
| OutputPath="$(WorkloadManifestPath)" /> | ||
|
|
||
| <ItemGroup> | ||
| <PackageFile Include="$(WorkloadManifestPath)" TargetPath="data" /> | ||
| <PackageFile Include="WorkloadManifest.targets" TargetPath="data" /> | ||
| </ItemGroup> | ||
| </Target> | ||
|
|
||
| <Import Project="$([MSBuild]::GetPathOfFileAbove(Directory.Build.targets))" /> | ||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,256 @@ | ||
| { | ||
| "version": 1, | ||
| "workloads": { | ||
| "microsoft-net-runtime-browser-native": { | ||
| "description": "Browser Runtime native performance tools", | ||
| "packs": [ | ||
| "Microsoft.NETCore.App.Runtime.Mono.browser-wasm", | ||
| "Microsoft.NET.Runtime.MonoAOTCompiler.Task", | ||
| "Microsoft.NET.Runtime.WebAssembly.Sdk", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.browser-wasm", | ||
| "Microsoft.NET.Runtime.Emscripten.Node", | ||
| "Microsoft.NET.Runtime.Emscripten.Python", | ||
| "Microsoft.NET.Runtime.Emscripten.Sdk" | ||
| ] | ||
| }, | ||
| "microsoft-net-runtime-android": { | ||
| "abstract": true, | ||
| "description": "Android Mono Runtime and AOT Workload", | ||
| "packs": [ | ||
| "Microsoft.NET.Runtime.MonoAOTCompiler.Task", | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-arm", | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-arm64", | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-x64", | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-x86", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.android-x64", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm64" | ||
| ] | ||
| }, | ||
| "microsoft-net-runtime-ios": { | ||
| "abstract": true, | ||
| "description": "iOS Mono Runtime and AOT Workload", | ||
| "packs": [ | ||
| "Microsoft.NET.Runtime.MonoAOTCompiler.Task", | ||
| "Microsoft.NETCore.App.Runtime.Mono.ios-arm", | ||
| "Microsoft.NETCore.App.Runtime.Mono.ios-arm64", | ||
| "Microsoft.NETCore.App.Runtime.Mono.iossimulator", | ||
| "Microsoft.NETCore.App.Runtime.Mono.iossimulator-x86", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.ios-arm", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.ios-arm64", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.iossimulator", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.iossimulator-x86" | ||
| ], | ||
| "platforms": [ "osx-arm64", "osx-x64" ] | ||
| }, | ||
| "microsoft-net-runtime-tvos": { | ||
| "abstract": true, | ||
| "description": "tvOS Mono Runtime and AOT Workload", | ||
| "packs": [ | ||
| "Microsoft.NET.Runtime.MonoAOTCompiler.Task", | ||
| "Microsoft.NETCore.App.Runtime.Mono.tvos-arm64", | ||
| "Microsoft.NETCore.App.Runtime.Mono.tvos-x64", | ||
| "Microsoft.NETCore.App.Runtime.Mono.tvossimulator", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.tvos-arm64", | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.tvossimulator" | ||
| ], | ||
| "platforms": [ "osx-arm64", "osx-x64" ] | ||
| } | ||
| }, | ||
| "packs": { | ||
| "Microsoft.NET.Runtime.RuntimeConfigParser.Task": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NET.Runtime.MonoAOTCompiler.Task": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NET.Runtime.WebAssembly.Sdk": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-arm": { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-arm64": { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-x64": { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.android-x86": { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.android-x86": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "win-x64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.android-x86", | ||
| "linux-x64": "Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x86", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-x86", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-x86" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.android-x64": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "win-x64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.android-x64", | ||
| "linux-x64": "Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-x64", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-x64", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-x64" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "win-x64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.android-arm", | ||
| "linux-x64": "Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-arm", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-arm" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm64": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "win-x64": "Microsoft.netcore.app.runtime.aot.win-x64.Cross.android-arm64", | ||
| "linux-x64": "Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.android-arm64", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-arm64", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.android-arm64" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.ios-arm" : { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.ios-arm64" : { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.iossimulator" : { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.Mono.iossimulator-arm64", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.Mono.iossimulator-x64" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.iossimulator-x86" : { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.Mono.iossimulator-x86" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.tvos-arm64": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.tvos-arm64", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.tvos-arm64", | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.tvos-arm64" : { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.tvossimulator" : { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.Mono.tvossimulator-arm64", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.Mono.tvossimulator-x64" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.tvossimulator": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.tvossimulator-arm64", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.tvossimulator-x64" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.ios-arm": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm", | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.ios-arm64": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.ios-arm64", | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.iossimulator": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.iossimulator-arm64", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.iossimulator-x64" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.iossimulator-x86": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.iossimulator-x86" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.AOT.Cross.browser-wasm": { | ||
| "kind": "Sdk", | ||
| "version": "${PackageVersion}", | ||
| "alias-to": { | ||
| "win-x86": "Microsoft.NETCore.App.Runtime.AOT.win-x86.Cross.browser-wasm", | ||
| "win-x64": "Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm", | ||
| "linux-x64": "Microsoft.NETCore.App.Runtime.AOT.linux-x64.Cross.browser-wasm", | ||
| "osx-x64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.browser-wasm", | ||
| "osx-arm64": "Microsoft.NETCore.App.Runtime.AOT.osx-x64.Cross.browser-wasm" | ||
| } | ||
| }, | ||
| "Microsoft.NETCore.App.Runtime.Mono.browser-wasm" : { | ||
| "kind": "framework", | ||
| "version": "${PackageVersion}" | ||
| }, | ||
| "Microsoft.NET.Runtime.Emscripten.Node" : { | ||
| "kind": "Sdk", | ||
| "version": "${EmscriptenVersion}", | ||
| "alias-to": { | ||
| "win-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Node.win-x64", | ||
| "linux-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Node.linux-x64", | ||
| "osx-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Node.osx-x64", | ||
| "osx-arm64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Node.osx-x64" | ||
| } | ||
| }, | ||
| "Microsoft.NET.Runtime.Emscripten.Python" : { | ||
| "kind": "Sdk", | ||
| "version": "${EmscriptenVersion}", | ||
| "alias-to": { | ||
| "win-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Python.win-x64", | ||
| "osx-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Python.osx-x64", | ||
| "osx-arm64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Python.osx-x64" | ||
| } | ||
| }, | ||
| "Microsoft.NET.Runtime.Emscripten.Sdk" : { | ||
| "kind": "Sdk", | ||
| "version": "${EmscriptenVersion}", | ||
| "alias-to": { | ||
| "win-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.win-x64", | ||
| "linux-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.linux-x64", | ||
| "osx-x64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.osx-x64", | ||
| "osx-arm64": "Microsoft.NET.Runtime.Emscripten.2.0.12.Sdk.osx-x64" | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| <Project> | ||
|
Member
There was a problem hiding this comment. If this is a shipping package then it needs the copyright section: https://github.com/dotnet/arcade/blob/cc512d28c9368336a2893172cbd45dc27960e304/src/Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk/src/build/Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk.props#L1 |
||
| <PropertyGroup Condition="'$(RuntimeIdentifier)' == 'browser-wasm'"> | ||
| <UsingBrowserRuntimeWorkload Condition="'$(RunAOTCompilation)' == 'true' or '$(UsingMicrosoftNETSdkBlazorWebAssembly)' != 'true'" >true</UsingBrowserRuntimeWorkload> | ||
| <UsingBrowserRuntimeWorkload Condition="'$(UsingBrowserRuntimeWorkload)' == ''" >$(WasmNativeWorkload)</UsingBrowserRuntimeWorkload> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(UsingMicrosoftNETSdkBlazorWebAssembly)' == 'true' and '$(UsingBrowserRuntimeWorkload)' == 'true'"> | ||
| <WasmGenerateAppBundle>false</WasmGenerateAppBundle> | ||
| <UsingBlazorAOTWorkloadManifest>true</UsingBlazorAOTWorkloadManifest> | ||
| </PropertyGroup> | ||
|
|
||
| <Import Condition="'$(RunAOTCompilation)' == 'true'" Project="Sdk.props" Sdk="Microsoft.NET.Runtime.MonoAOTCompiler.Task" /> | ||
|
|
||
| <ImportGroup Condition="'$(TargetPlatformIdentifier)' == 'android' and '$(RunAOTCompilation)' == 'true'"> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-x86" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-x64" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.android-arm64" /> | ||
| </ImportGroup> | ||
|
|
||
| <ImportGroup Condition="'$(TargetPlatformIdentifier)' == 'ios' and '$(RunAOTCompilation)' == 'true'"> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.ios-arm" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.ios-arm64" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.ios-x86" /> | ||
| </ImportGroup> | ||
|
|
||
| <ImportGroup Condition="'$(TargetPlatformIdentifier)' == 'tvos' and '$(RunAOTCompilation)' == 'true'"> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.tvos-arm64" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.tvos-x64" /> | ||
| </ImportGroup> | ||
|
|
||
| <ImportGroup Condition="'$(TargetPlatformIdentifier)' == 'iossimulator' and '$(RunAOTCompilation)' == 'true'"> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.iossimulator" /> | ||
| </ImportGroup> | ||
|
|
||
| <ImportGroup Condition="'$(TargetPlatformIdentifier)' == 'tvossimulator' and '$(RunAOTCompilation)' == 'true'"> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETCore.App.Runtime.AOT.Cross.tvossimulator" /> | ||
| </ImportGroup> | ||
|
|
||
| <ImportGroup Condition="'$(RuntimeIdentifier)' == 'browser-wasm' and '$(UsingBrowserRuntimeWorkload)' == 'true'"> | ||
| <Import Project="Sdk.targets" Sdk="Microsoft.NET.Runtime.WebAssembly.Sdk" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NET.Runtime.Emscripten.Python" Condition="!$([MSBuild]::IsOsPlatform('Linux'))" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NET.Runtime.Emscripten.Node" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NET.Runtime.Emscripten.Sdk" /> | ||
| <Import Project="Sdk.props" Sdk="Microsoft.NETcore.App.Runtime.AOT.Cross.browser-wasm" /> | ||
| </ImportGroup> | ||
|
Member
There was a problem hiding this comment. nit: indentations in this file are off. We use two spaces in all our msbuild files in the repo. |
||
| </Project> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please move these two properties down to the other property group and add a comment to indicate which repo these properties are targeting? Similar to all the other properties in this file (see below).