Revert "[release/5.0] When marshalling a layout class, fall-back to dynamically marshalling the type if it doesn't match the static type in the signature." #50883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc: @Anipik @jeffschwMSFT |
jeffschwMSFT
approved these changes
Apr 7, 2021
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. We will take for consideration for 5.0.6
Member
This was referenced Apr 8, 2021
Contributor
yes we have time to revert this change for 5.0.6 |
leecow
added
Servicing-approved
Member
|
@jkoritzinsky can you double check the ci and then @Anipik we should be ready to merge. |
Member
Author
|
CI is failing due to #50746, which at its root is an ongoing Azure ICM. |
Contributor
|
Merging this one as all the failures were infra related |
jkoritzinsky
added a commit
that referenced
this pull request
Apr 9, 2021
Anipik
pushed a commit
that referenced
this pull request
May 5, 2021
* [release/5.0] Use adjusted parent layout size to handle a non-zero-sized class inheriting from a zero-sized class that inherits from another zero-sized class. Fixes handling of zero-sized parent types that have zero-sized parent types. * Revert "[release/5.0] When marshalling a layout class, fall-back to dynamically marshalling the type if it doesn't match the static type in the signature. (#50138)" (#50883) (#51021) This reverts commit b71bb59.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #50138
We'll combine this with #50882 so all of the fixes go in at once.