Fix pointer tearing in JIT_MemSet helper on ARM64 #50273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/gc |
Member
Author
|
Root cause analysis in #49859 (comment). This matches what we do on other platforms. It is not perfect since there is a theoretical chance that memset may tear pointers, but this will do for now. |
mangod9
reviewed
Mar 26, 2021
mangod9
approved these changes
Mar 26, 2021
Member
|
@AntonLapounov as fyi. |
Contributor
|
@jkotas Thanks |
Anipik
pushed a commit
that referenced
this pull request
Apr 6, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49859