[release/5.0] Fix GCDesc::GetNumPointers for collectible types #49801
Conversation
|
Tagging subscribers to this area: @dotnet/gc |
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Please get a cr and we will take for consideration in 5.0.x
davidwrighton
left a comment
davidwrighton
left a comment
There was a problem hiding this comment.
Assuming you agree with my comment, this is approved.
| CGCDescSeries* cur = map->GetHighestSeries(); | ||
| ptrdiff_t cnt = (ptrdiff_t)map->GetNumSeries(); | ||
|
|
||
| if (cnt >= 0) |
There was a problem hiding this comment.
My analysis indicates the change here to change from > to >= is a small performance optimization. From my analysis cnt == 0 can't actually happen so this is ok, but I want to verify that was the rationale.
There was a problem hiding this comment.
My primary motivation for this was to make the conditions and flow to be more similar to the go_through_object macros, so that easier to validate that the logic in this method matches it.
You are right that the side-effect is minor perf optimization.
jeffschwMSFT
removed
the
Servicing-consider
ghost
locked as resolved and limited conversation to collaborators
6 participants
Customer Impact
Intermittent crash during GC in complex scenarios that use collectible types
Description
It looks like a bug that has been there since forever. The bug just results into occasional small GC inefficiency most of the time. The crash only happens when all of the following is true:
Regression?
No.
Risk (see taxonomy)
Low. Fix validated by the customer.
Fixes #49684