Fix incomplete dumps generated by createdump #49468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon Issue DetailsThere are memory regions > 4GB in size that overflowed a 32bit size value. Changed to 64bit. Fixes issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1277488?src=WorkItemMention&src-action=artifact_link This also may be the cause of issue dotnet/diagnostics#1780
|
sdmaclea
approved these changes
Mar 11, 2021
Contributor
sdmaclea
left a comment
sdmaclea
left a comment
There was a problem hiding this comment.
LGTM
z --> size_t
Learn something new every day
sdmaclea
reviewed
Mar 11, 2021
Contributor
There was a problem hiding this comment.
size should probably be declared above as size_t ... Otherwise
Suggested change
| size_t bytesToRead = std::min(size, sizeof(m_tempBuffer)); | |
| size_t bytesToRead = std::min((size_t)size, sizeof(m_tempBuffer)); |
2021-03-11T02:11:41.5645060Z /Users/runner/work/1/s/src/coreclr/debug/createdump/dumpwriter.cpp:212:38: error: no matching function for call to 'min'
2021-03-11T02:11:41.5744730Z size_t bytesToRead = std::min(size, sizeof(m_tempBuffer));
2021-03-11T02:11:41.5845290Z ^~~~~~~~
2021-03-11T02:11:41.5947840Z /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2560:1: note: candidate template ignored: deduced conflicting types for parameter '_Tp' ('unsigned long long' vs. 'unsigned long')
2021-03-11T02:11:41.6050380Z min(const _Tp& __a, const _Tp& __b)
2021-03-11T02:11:41.6152150Z ^
2021-03-11T02:11:41.6255530Z /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2571:1: note: candidate template ignored: could not match 'initializer_list<type-parameter-0-0>' against 'unsigned long long'
2021-03-11T02:11:41.6357920Z min(initializer_list<_Tp> __t, _Compare __comp)
2021-03-11T02:11:41.6460080Z ^
2021-03-11T02:11:41.6561170Z /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2551:1: note: candidate function template not viable: requires 3 arguments, but 2 were provided
2021-03-11T02:11:41.6662240Z min(const _Tp& __a, const _Tp& __b, _Compare __comp)
2021-03-11T02:11:41.6761820Z ^
2021-03-11T02:11:41.6863770Z /Applications/Xcode_12.2.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/algorithm:2580:1: note: candidate function template not viable: requires single argument '__t', but 2 arguments were provided
2021-03-11T02:11:41.6993010Z min(initializer_list<_Tp> __t)
2021-03-11T02:11:41.7195180Z ^
2021-03-11T02:11:42.0217020Z 1 error generated.
sdmaclea
approved these changes
Mar 11, 2021
mikem8361
force-pushed
the
fixcreatedump
branch
from
805ab0e to
2d8dbf2
Compare
|
Hello @mikem8361! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
mikem8361
pushed a commit
to mikem8361/runtime
that referenced
this pull request
Mar 16, 2021
The core dump generated for a app that has large GC heaps (>4GB) are don't contain all the memory needed in process. This is because of a 32bit size value overflow; changed to size_t. Multiple customers have reported this problem in 3.1 and 5.0. Issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1277488?src=WorkItemMention&src-action=artifact_link and dotnet/diagnostics#1780
Anipik
pushed a commit
that referenced
this pull request
Apr 6, 2021
) The core dump generated for a app that has large GC heaps (>4GB) are don't contain all the memory needed in process. This is because of a 32bit size value overflow; changed to size_t. Multiple customers have reported this problem in 3.1 and 5.0. Issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1277488?src=WorkItemMention&src-action=artifact_link and dotnet/diagnostics#1780
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are memory regions > 4GB in size that overflowed a 32bit size value. Changed to 64bit.
Fixes issue: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1277488?src=WorkItemMention&src-action=artifact_link
This also may be the cause of issue dotnet/diagnostics#1780