Skip to content

[Arm64] Implement MultiplyHigh #47362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echesakov merged 10 commits into from
Jan 28, 2021
Merged

[Arm64] Implement MultiplyHigh #47362

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a3357da
Add MultiplyHigh in src/coreclr/jit/hwintrinsiclistarm64.h
echesakov Jan 22, 2021
8e84e0a
Add MultiplyHigh in ArmBase.cs ArmBase.PlatformNotSupported.cs
echesakov Jan 22, 2021
ea5504b
Update System.Runtime.Intrinsics.cs
echesakov Jan 22, 2021
b3b4dfa
Use ArmBase.Arm64.MultiplyHigh in BigMul in Math.cs
echesakov Jan 22, 2021
1567a18
Implement MultiplyHigh in src/coreclr/jit/hwintrinsic.cpp
echesakov Jan 23, 2021
59945ef
Add MultiplyHigh in GenerateTests.csx
echesakov Jan 23, 2021
3391d12
Update src/tests/JIT/HardwareIntrinsics/Arm/ArmBase.Arm64/*
echesakov Jan 23, 2021
16cd135
Implement MultiplyHigh in Helpers.cs Helpers.tt
echesakov Jan 25, 2021
d8455c2
Support MultiplyHigh in mono
echesakov Jan 27, 2021
9e94fba
Add spaces before parens in src/mono/mono/mini/mini-llvm.c
echesakov Jan 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/mono/mono/mini/mini-llvm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9086,6 +9086,22 @@ process_bb (EmitContext *ctx, MonoBasicBlock *bb)
values [ins->dreg] = LLVMBuildCall (builder, get_intrins (ctx, ins->opcode == OP_LSCNT32 ? INTRINS_CTLZ_I32 : INTRINS_CTLZ_I64), args, 2, "");
break;
}
case OP_ARM64_SMULH:
case OP_ARM64_UMULH: {
LLVMValueRef op1, op2;
if (ins->opcode == OP_ARM64_SMULH) {
op1 = LLVMBuildSExt (builder, lhs, LLVMInt128Type(), "");
op2 = LLVMBuildSExt (builder, rhs, LLVMInt128Type(), "");
} else {
op1 = LLVMBuildZExt (builder, lhs, LLVMInt128Type(), "");
op2 = LLVMBuildZExt (builder, rhs, LLVMInt128Type(), "");
}
LLVMValueRef mul = LLVMBuildMul (builder, op1, op2, "");
LLVMValueRef hi64 = LLVMBuildLShr (builder, mul,
LLVMConstInt(LLVMInt128Type (), 64, FALSE), "");
values [ins->dreg] = LLVMBuildTrunc (builder, hi64, LLVMInt64Type(), "");
break;
}
#endif

case OP_DUMMY_USE:
Expand Down
2 changes: 2 additions & 0 deletions src/mono/mono/mini/mini-ops.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,4 +1578,6 @@ MINI_OP(OP_POPCNT64, "popcnt64", LREG, LREG, NONE)
#ifdef TARGET_ARM64
MINI_OP(OP_LSCNT32, "lscnt32", IREG, IREG, NONE)
MINI_OP(OP_LSCNT64, "lscnt64", LREG, LREG, NONE)
MINI_OP(OP_ARM64_SMULH, "arm64_smulh", LREG, LREG, LREG)
MINI_OP(OP_ARM64_UMULH, "arm64_umulh", LREG, LREG, LREG)
#endif // TARGET_ARM64
4 changes: 4 additions & 0 deletions src/mono/mono/mini/simd-intrinsics-netcore.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,6 +807,7 @@ emit_invalid_operation (MonoCompile *cfg, const char* message)
static SimdIntrinsic armbase_methods [] = {
{SN_LeadingSignCount},
{SN_LeadingZeroCount},
{SN_MultiplyHigh},
{SN_ReverseElementBits},
{SN_get_IsSupported}
};
Expand Down Expand Up @@ -847,6 +848,9 @@ emit_arm64_intrinsics (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSignatur
return emit_simd_ins_for_sig (cfg, klass, arg0_i32 ? OP_LZCNT32 : OP_LZCNT64, 0, arg0_type, fsig, args);
case SN_LeadingSignCount:
return emit_simd_ins_for_sig (cfg, klass, arg0_i32 ? OP_LSCNT32 : OP_LSCNT64, 0, arg0_type, fsig, args);
case SN_MultiplyHigh:
return emit_simd_ins_for_sig (cfg, klass,
(arg0_type == MONO_TYPE_I8 ? OP_ARM64_SMULH : OP_ARM64_UMULH), 0, arg0_type, fsig, args);
case SN_ReverseElementBits:
return emit_simd_ins_for_sig (cfg, klass,
(is_64bit ? OP_XOP_I8_I8 : OP_XOP_I4_I4),
Expand Down