[release/5.0-rc2] Make EventPipeProviderCallbackData own the filter data #42368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoyosjs
approved these changes
Sep 17, 2020
jeffschwMSFT
approved these changes
Sep 17, 2020
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Please ask @noahfalk to do a cr.
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
added
Servicing-approved
Member
|
Approved for RC2 via email |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #42307 to release/5.0-rc2
/cc @davmason
Customer Impact
There is a use after free bug in the EventPipe disable path, specifically in the code that deals with filter data. If a session specifies filter data for a provider they have a chance that the runtime could crash when disabling the session.
Testing
To test this change I modified the runtime to purposefully overwrite the filter data string immediately before it was freed in the destructor of EventPipeSessionProvider. Before this change you can see the modified string, after my change the filter data is unchanged.
Risk
Low - the fix is small, easy to reason about, and well understood.