Stop ignoring **/_.pdb files in Docker containers #38027
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Networking stress tests running on Linux are failing in master at building runtime inside container due to a missing `_.pdb` files (e.g. `/repo/src/coreclr/src/.nuget/_.pdb`) This PR makes Docker to include those files into containers.
Collaborator
|
I couldn't figure out the best area label to add to this PR. Please help me learn by adding exactly one area label. |
|
Tagging subscribers to this area: @ViktorHofer |
Contributor
Author
|
/azp run runtime-libraries stress-http |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-libraries stress-ssl |
|
Azure Pipelines successfully started running 1 pipeline(s). |
aik-jahoda
approved these changes
Jun 17, 2020
aik-jahoda
reviewed
Jun 17, 2020
| **/*.obj | ||
| **/*.pch | ||
| **/*.pdb | ||
| !**/_.pdb |
Contributor
There was a problem hiding this comment.
It worth a comment with explanation why one kind of pdb is ignored while other allowed.
Member
|
I think I added this change to: #35011 -- but fine to split it in a separate PR. |
safern
approved these changes
Jun 17, 2020
Contributor
Author
|
Closing it as obsolete since #35011 was merged. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Networking stress tests running on Linux are failing in master at building runtime inside container due to a missing
_.pdbfiles (e.g./repo/src/coreclr/src/.nuget/_.pdb) This PR makes Docker to include those files into containers.