Remove Stream.CopyTo{Async} delegate overloads #37750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
changed the title
jkotas
approved these changes
Jun 11, 2020
We added these earlier in the .NET 5 cycle, but they're not providing the benefits we hoped, and are likely to cause confusion and actually result in de-optimizations in some cases. We can re-add them in the future should a stronger need / impact present itself.
stephentoub
force-pushed
the
removecopyto
branch
from
05deb32 to
b57ef62
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added these earlier in the .NET 5 cycle, but they're not providing the benefits we hoped, and are likely to cause confusion and actually result in de-optimizations in some cases. We can re-add them in the future should a stronger need / impact present itself.
(Thanks to @manandre for his efforts to add these initially.)
Closes #22472