Skip to content

Rework rejit test to ensure subprocess environment is suitable #36420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020
Merged

Rework rejit test to ensure subprocess environment is suitable #36420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/coreclr/tests/src/profiler/common/ProfilerTestRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace Profiler.Tests
public enum ProfileeOptions
{
None = 0,
DisableTieredCompilation,
OptimizationSensitive,
NoStartupAttach
}

Expand All @@ -41,10 +41,12 @@ public static int Run(string profileePath,
envVars.Add("CORECLR_PROFILER", "{" + profilerClsid + "}");
}

if (profileeOptions.HasFlag(ProfileeOptions.DisableTieredCompilation))
if (profileeOptions.HasFlag(ProfileeOptions.OptimizationSensitive))
{
Console.WriteLine("Disabling tiered compilation.");
Console.WriteLine("Disabling tiered compilation, jitstress, and minopts.");
envVars.Add("COMPlus_TieredCompilation", "0");
envVars.Add("COMPlus_JitStress", "0");
envVars.Add("COMPlus_JITMinOpts", "0");
}

string profilerPath = GetProfilerPath();
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/tests/src/profiler/rejit/rejit.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ public static int Main(string[] args)
return ProfilerTestRunner.Run(profileePath: System.Reflection.Assembly.GetExecutingAssembly().Location,
testName: "ReJITWithInlining",
profilerClsid: ReJitProfilerGuid,
profileeOptions: ProfileeOptions.DisableTieredCompilation);
profileeOptions: ProfileeOptions.OptimizationSensitive);
}
}
}