Return the correct OSVersion on OSX like systems. #36029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
reviewed
May 7, 2020
stephentoub
reviewed
May 8, 2020
stephentoub
reviewed
May 8, 2020
src/libraries/System.Runtime.Extensions/tests/System/EnvironmentTests.cs
Show resolved
Hide resolved
jkotas
reviewed
May 8, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.OSX.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
May 8, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.OSX.cs
Outdated
Show resolved
Hide resolved
rolfbjarne
reviewed
May 8, 2020
src/libraries/System.Private.CoreLib/src/System/Environment.OSX.cs
Outdated
Show resolved
Hide resolved
Move interop code to Common\src\Interop. Specify the full path to libobjc.dylib. Fix objc_msgSend_stret for ARM64.
jkotas
reviewed
May 8, 2020
jkotas
approved these changes
May 8, 2020
rolfbjarne
approved these changes
May 11, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #34977
Here's a link to the underlying API being invoked. I tested this code both on a .NET 5 console app on macOS
10.15.4and in an iOS simulator running iOS13.4.1. The method returned the respective version for each. I didn't test tvOS though - I don't have a device.