Skip to content

[mono] retry mono_threads_pthread_kill if result == EAGAIN on Linux #33966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lambdageek merged 3 commits into from
Mar 24, 2020
Merged

[mono] retry mono_threads_pthread_kill if result == EAGAIN on Linux #33966

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6d0c75
[mono] retry mono_threads_pthread_kill if result == EAGAIN on Linux
lambdageek Mar 23, 2020
1843da0
fix warnings; fix Android build failure; print warning if sleeping
lambdageek Mar 23, 2020
9757e2b
if the retry count is exceeded, error out
lambdageek Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions src/mono/mono/utils/mono-threads-posix.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,16 +170,25 @@ mono_threads_pthread_kill (MonoThreadInfo *info, int signum)
{
THREADS_SUSPEND_DEBUG ("sending signal %d to %p[%p]\n", signum, info, mono_thread_info_get_tid (info));

const int signal_queue_ovf_retry_count G_GNUC_UNUSED = 5;
const gulong signal_queue_ovf_sleep_us G_GNUC_UNUSED = 10 * 1000; /* 10 milliseconds */
int retry_count G_GNUC_UNUSED = 0;
int result;

#if defined (__linux__)
redo:
#endif

#ifdef USE_TKILL_ON_ANDROID
int old_errno = errno;
{
int old_errno = errno;

result = tkill (info->native_handle, signum);
result = tkill (info->native_handle, signum);

if (result < 0) {
result = errno;
mono_set_errno (old_errno);
if (result < 0) {
result = errno;
mono_set_errno (old_errno);
}
}
#elif defined (HAVE_PTHREAD_KILL)
result = pthread_kill (mono_thread_info_get_tid (info), signum);
Expand All @@ -204,10 +213,25 @@ mono_threads_pthread_kill (MonoThreadInfo *info, int signum)
result != ESRCH
#if defined (__MACH__) && defined (ENOTSUP)
&& result != ENOTSUP
#endif
#if defined (__linux__)
&& !(result == EAGAIN && retry_count < signal_queue_ovf_retry_count)
#endif
)
g_error ("%s: pthread_kill failed with error %d - potential kernel OOM or signal queue overflow", __func__, result);

#if defined (__linux__)
if (result == EAGAIN && retry_count < signal_queue_ovf_retry_count) {
/* HACK: if the signal queue overflows on linux, try again a couple of times.
* Tries to address https://github.com/dotnet/runtime/issues/32377
*/
g_warning ("%s: pthread_kill failed with error %d - potential kernel OOM or signal queue overflow, sleeping for %ld microseconds", __func__, result, signal_queue_ovf_sleep_us);
g_usleep (signal_queue_ovf_sleep_us);
++retry_count;
goto redo;
}
#endif

return result;
}

Expand Down