Skip to content

Conversation

@CoffeeFlux
Copy link
Contributor

@CoffeeFlux CoffeeFlux commented Feb 13, 2020

This includes some other minor cleanup to the netcore hosting functions.

Setting assemblies_path with APP_PATHS despite it also being set by MONO_PATH doesn't scare me too much because:

  1. Anyone using MONO_PATH is probably not going through the hosting API and is using mono-sgen directly
  2. The default host doesn't set APP_PATHS unless Microsoft.NETCore.DotNetHostPolicy.SetAppPaths is set to 1 in the .runtimeconfig.json (which is rare, and we've worked fine without APP_PATHS being set at all up until now)
  3. This is a temporary measure; we will have to refactor our preload hook when we want to properly support the other loader properties anyway

@vitek-karas
Copy link
Member

Nit about APP_PATHS: the host will set it if the .runtimeconfig.json contains property Microsoft.NETCore.DotNetHostPolicy.SetAppPaths set to 1. Almost nobody does that, so I don't think it matters - but just to make thing complete 😇

@CoffeeFlux
Copy link
Contributor Author

Ah good to know, thanks! I agree it's still not a concern, but worth keeping in mind - I'll update the description to be more accurate.

@CoffeeFlux CoffeeFlux merged commit e4d7893 into dotnet:master Feb 19, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-AssemblyLoader-mono runtime-mono specific to the Mono runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants