Skip to content

Minor R2RDump improvements #32178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trylek merged 1 commit into from
Feb 12, 2020
Merged

Minor R2RDump improvements #32178

trylek merged 1 commit into from
Feb 12, 2020

Conversation

@trylek
Copy link
Member

@trylek trylek commented Feb 12, 2020

Based on JanV's suggestions and based on my own composite R2R work
I have made a few small improvements in R2RDump:

  1. When normalization is on, we newly also normalize transition
    records for a particular IP address.

  2. New option --hide-transitions suppresses transition information
    in the disassembly completely.

  3. Logic for parsing the new OwnerCompositeExecutable R2R section.

Thanks

Tomas

@trylek
Minor R2RDump improvements
1dd7532 
Based on JanV's suggestions and based on my own composite R2R work
I have made a few small improvements in R2RDump:

1) When normalization is on, we newly also normalize transition
records for a particular IP address.

2) New option --hide-transitions suppresses transition information
in the disassembly completely.

3) Logic for parsing the new OwnerCompositeExecutable R2R section.

Thanks

Tomas
@trylek trylek requested a review from janvorli February 12, 2020 16:06
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-R2RDump-coreclr Ready-to-run image dump tool label Feb 12, 2020
janvorli
janvorli approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@trylek trylek merged commit 76bc84b into dotnet:master Feb 12, 2020
@trylek trylek deleted the R2RDumpGCInfo branch February 12, 2020 19:55
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@janvorli janvorli janvorli approved these changes

Assignees

No one assigned

Labels

area-R2RDump-coreclr Ready-to-run image dump tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trylek @janvorli @Dotnet-GitSync-Bot