Skip to content

Conversation

@stephentoub
Copy link
Member

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on tests primarily, otherwise LGTM.

@GrabYourPitchforks
Copy link
Member

:shipit:

@ahsonkhan
Copy link
Contributor

ahsonkhan commented Feb 12, 2020

fyi @carlossanlop, @maryamariyan - label for "new api needs doc" missing.

Copy link
Contributor

@ahsonkhan ahsonkhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good.

@ahsonkhan ahsonkhan added this to the 5.0 milestone Feb 12, 2020
@ahsonkhan
Copy link
Contributor

There are a few other places where we could call the new API. Did you intentionally exclude them:
https://github.com/dotnet/runtime/search?l=C%23&q=.GetBits

For example:

return (byte)((decimal.GetBits((decimal)value)[3] & 0x00ff0000) >> 0x10);

return (byte)((decimal.GetBits((decimal)value)[3] & 0x00ff0000) >> 0x10);

@stephentoub
Copy link
Member Author

Did you intentionally exclude them

Yes, two of those target netstandard2.0. The other one is a code gen tool for which we have no tests and in which such a change won't be at all measurable.

@maryamariyan
Copy link
Contributor

maryamariyan commented Feb 12, 2020

@ahsonkhan I haven't enabled it on the bot yet. (happens once every two days instead)

@maryamariyan
Copy link
Contributor

@ahsonkhan I just enabled auto-labeling PRs with "new-api-needs-documentation" label. Should show up on future PRs.

@stephentoub stephentoub merged commit 6c30d91 into dotnet:master Feb 13, 2020
@stephentoub stephentoub deleted the decimalspan branch February 13, 2020 02:43
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decimal forgotten by Span<T> APIs

6 participants