Skip to content

[mono] Review [SkipOnTargetFramework(TargetFrameworkMonikers.Mono...] occurrences #31920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkotas merged 2 commits into from
Feb 8, 2020
Merged

[mono] Review [SkipOnTargetFramework(TargetFrameworkMonikers.Mono...] occurrences #31920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d60b92
Review test attributes
MaximLipnin Feb 7, 2020
30da324
Disable System.Threading.Tests.SynchronizationContextTests.WaitNotifi…
MaximLipnin Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/libraries/System.Data.Common/tests/System/Data/Common/DbCommandTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,7 @@ protected override DbDataReader ExecuteDbDataReader(CommandBehavior behavior)
}
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "GC has different behavior on Mono")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
public void CanBeFinalized()
{
FinalizingCommand.CreateAndRelease();
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Data.Common/tests/System/Data/Common/DbConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,7 @@ private class TestDbProviderFactory : DbProviderFactory
public static DbProviderFactory Instance = new TestDbProviderFactory();
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "GC has different behavior on Mono")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
public void CanBeFinalized()
{
FinalizingConnection.CreateAndRelease();
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Diagnostics.Process/tests/ProcessTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1316,8 +1316,7 @@ public void StandardInput_GetNotRedirected_ThrowsInvalidOperationException()
Assert.Throws<InvalidOperationException>(() => process.StandardInput);
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "GC has different behavior on Mono")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
public void CanBeFinalized()
{
FinalizingProcess.CreateAndRelease();
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Net.Ping/tests/FunctionalTests/PingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,8 +773,7 @@ private static async Task SendPingAsync(Func<Ping, Task<PingReply>> sendPing, Ac
pingResultValidator(pingResult);
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "GC has different behavior on Mono")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
public void CanBeFinalized()
{
FinalizingPing.CreateAndRelease();
Expand Down
3 changes: 0 additions & 3 deletions src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,7 +1148,6 @@ public void BeginGetRequestStream_CreatePostRequestThenAbort_ThrowsWebException(
}

[Theory, MemberData(nameof(EchoServers))]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "no exception thrown on mono")]
public void BeginGetRequestStream_CreatePostRequestThenCallTwice_ThrowsInvalidOperationException(Uri remoteServer)
{
HttpWebRequest request = HttpWebRequest.CreateHttp(remoteServer);
Expand Down Expand Up @@ -1715,7 +1714,6 @@ await LoopbackServer.CreateServerAsync((server, url) =>
}

[ActiveIssue("https://github.com/dotnet/corefx/issues/19083")]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "https://github.com/dotnet/corefx/issues/19083")]
[Fact]
public async Task Abort_BeginGetRequestStreamThenAbort_EndGetRequestStreamThrowsWebException()
{
Expand All @@ -1737,7 +1735,6 @@ await LoopbackServer.CreateServerAsync((server, url) =>
});
}

[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "ResponseCallback not called after Abort on mono")]
[Fact]
public async Task Abort_BeginGetResponseThenAbort_ResponseCallbackCalledBeforeAbortReturns()
{
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Net.Requests/tests/LoggingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.Net.Tests
public class LoggingTest
{
[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "NetEventSource is only part of .NET Core.")]
[SkipOnCoreClr("System.Net.Tests are flaky", RuntimeConfiguration.Checked)]
public void EventSource_ExistsWithCorrectId()
{
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Net.WebHeaderCollection/tests/LoggingTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.Net.Tests
public class WebHeaderCollectionLoggingTest
{
[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "NetEventSource is only part of .NET Core")]
public void EventSource_ExistsWithCorrectId()
{
Type esType = typeof(WebHeaderCollection).Assembly.GetType("System.Net.NetEventSource", throwOnError: true, ignoreCase: false);
Expand Down
3 changes: 0 additions & 3 deletions src/libraries/System.Net.WebHeaderCollection/tests/WebHeaderCollectionTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,6 @@ public void Add_InvalidHeader_ThrowsArgumentException(string header, string para
private const string CookieInvalid = "helloWorld";

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "Does not work in Mono")]
public void GetValues_MultipleSetCookieHeadersWithExpiresAttribute_Success()
{
WebHeaderCollection w = new WebHeaderCollection();
Expand All @@ -559,7 +558,6 @@ public void GetValues_MultipleSetCookieHeadersWithExpiresAttribute_Success()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "Does not work in Mono")]
public void GetValues_SingleSetCookieHeaderWithMultipleCookiesWithExpiresAttribute_Success()
{
WebHeaderCollection w = new WebHeaderCollection();
Expand Down Expand Up @@ -605,7 +603,6 @@ public void GetValues_SingleSetCookieHeaderWithMultipleCookiesWithNoAttribute_Su
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "Does not work in Mono")]
public void GetValues_InvalidSetCookieHeader_Success()
{
WebHeaderCollection w = new WebHeaderCollection();
Expand Down
6 changes: 0 additions & 6 deletions src/libraries/System.Threading.Thread/tests/ThreadTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ public static void ApartmentStateTest_Unix(
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void CurrentCultureTest_DifferentThread()
{
CultureInfo culture = (CultureInfo)CultureInfo.CurrentCulture.Clone();
Expand Down Expand Up @@ -404,7 +403,6 @@ public static void CurrentCultureTest()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void CurrentPrincipalTest_SkipOnDesktopFramework()
{
ThreadTestHelpers.RunTestInBackgroundThread(() => Assert.Null(Thread.CurrentPrincipal));
Expand Down Expand Up @@ -460,7 +458,6 @@ await Task.Run(() =>
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void CurrentPrincipalContextFlowTest_NotFlow()
{
ThreadTestHelpers.RunTestInBackgroundThread(async () =>
Expand Down Expand Up @@ -527,7 +524,6 @@ public static void CurrentThreadTest()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void ExecutionContextTest()
{
ThreadTestHelpers.RunTestInBackgroundThread(
Expand Down Expand Up @@ -705,7 +701,6 @@ public static void ThreadStateTest()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void AbortSuspendTest()
{
var e = new ManualResetEvent(false);
Expand Down Expand Up @@ -1079,7 +1074,6 @@ public static void StartTest()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void MiscellaneousTest()
{
Thread.BeginCriticalRegion();
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ public static void SetMinMaxThreadsTest()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void SetMinMaxThreadsTest_ChangedInDotNetCore()
{
int minw, minc, maxw, maxc;
Expand Down
1 change: 0 additions & 1 deletion src/libraries/System.Threading/tests/ExecutionContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ public static void FlowTest()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void CaptureThenSuppressThenRunFlowTest()
{
ThreadTestHelpers.RunTestInBackgroundThread(() =>
Expand Down
4 changes: 1 addition & 3 deletions src/libraries/System.Threading/tests/SynchronizationContextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ namespace System.Threading.Tests
public static class SynchronizationContextTests
{
[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "SynchronizationContext.Wait(IntPtr[], bool, int) is not implemented on Mono")]
public static void WaitTest()
{
var tsc = new TestSynchronizationContext();
Expand All @@ -37,14 +36,13 @@ public static void WaitTest()
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono)]
public static void WaitTest_ChangedInDotNetCore()
{
Assert.Throws<ArgumentNullException>(() => TestSynchronizationContext.WaitHelper(null, false, 0));
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "https://bugzilla.xamarin.com/show_bug.cgi?id=60568")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/31977", TargetFrameworkMonikers.Mono)]
public static void WaitNotificationTest()
Copy link
Member

@akoeplinger akoeplinger Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this test still fails. The bugzilla bug was marked as fixed so probably some other issue.

Can you please add a new issue for this and disable the test with ActiveIssue?

Copy link
Contributor Author

@MaximLipnin MaximLipnin Feb 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll do

{
ThreadTestHelpers.RunTestInBackgroundThread(() =>
Expand Down
3 changes: 1 addition & 2 deletions src/libraries/System.Threading/tests/ThreadLocalTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,7 @@ private static void RunThreadLocalTest8Helper(ManualResetEventSlim mres)
Assert.Throws<ObjectDisposedException>(() => values = tl.Values);
}

[Fact]
[SkipOnTargetFramework(TargetFrameworkMonikers.Mono, "This test requires precise stack scanning")]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsPreciseGcSupported))]
public static void RunThreadLocalTest8_Values_NegativeCases()
{
// Test that Dispose works and that objects are released on dispose
Expand Down