-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Update ILLinkTasksVersion dependency #2334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
Jan 30, 2020
| <!-- keep interface implementations --> | ||
| <ILLinkArgs>$(ILLinkArgs) --disable-opt unusedinterfaces</ILLinkArgs> | ||
| <!-- disable optimization to unblock dependencies bump --> | ||
| <ILLinkArgs>$(ILLinkArgs) --disable-opt ipconstprop</ILLinkArgs> |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe file an issue for reenabling this optimization?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stephentoub
approved these changes
Jan 30, 2020
ViktorHofer
added a commit
that referenced
this pull request
Feb 5, 2020
This reverts commit a05c599.
ViktorHofer
added a commit
that referenced
this pull request
Feb 5, 2020
trylek
added a commit
to trylek/runtime
that referenced
this pull request
Feb 10, 2020
…otnet#31807)" This reverts commit 334391b.
marek-safar
added a commit
to marek-safar/runtime
that referenced
this pull request
Feb 12, 2020
…otnet#31807)" This reverts commit 334391b.
ViktorHofer
pushed a commit
that referenced
this pull request
Feb 18, 2020
marek-safar
added a commit
to marek-safar/runtime
that referenced
this pull request
Mar 24, 2020
marek-safar
added a commit
that referenced
this pull request
Mar 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.