[8.0][browser][AOT] use response file for llvm-size#123538
Open
pavelsavara wants to merge 2 commits intodotnet:release/8.0-stagingfrom
Open
[8.0][browser][AOT] use response file for llvm-size#123538pavelsavara wants to merge 2 commits intodotnet:release/8.0-stagingfrom
pavelsavara wants to merge 2 commits intodotnet:release/8.0-stagingfrom
Conversation
pavelsavara
added
arch-wasm
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Member
Author
|
@jtorjo I created PR out of your file, so that we could test it and discuss it here. |
Member
Author
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
maraf
approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a command line length limitation issue when building Blazor WebAssembly applications with AOT. The issue occurs on Windows Server 2016 and lower where the command line limit is 8191 characters. When a large number of object files are passed to the llvm-size tool, the command line can exceed this limit causing build failures.
Changes:
- Introduces a response file for the llvm-size tool to avoid command line length limitations
- Creates the response file in the intermediate output directory containing quoted paths to all AOT object files
- Updates the llvm-size invocation to use the response file instead of passing files directly on the command line
Member
Author
|
failing WBT tests are not related, probably CI timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes our Mono AOT SDK for Wasm/Browser run also on old versions of windows without long path support.
Backport of #123548 to release/8.0 with modifications for Net8
Customer Impact
Fixes #123257
Regression
Testing
Automated tests on CI
Risk