-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Fix interpreting baud rate bitmask as decimal value #123348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrek-msft
wants to merge
10
commits into
dotnet:main
Choose a base branch
from
mrek-msft:dev/mrek/serial_baud_bitmask_bitrate_missmatch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
dfa96ac
Fix confusing baud bitmask (obtained from Win32) and actuall bitrate …
mrek-msft ee7ad79
Allow working with buggy device drivers providing int instead of bitmask
mrek-msft 9098b94
Add comment
mrek-msft 99796a4
Refactor and baud order fix
mrek-msft 487ee32
Fix bad refactor and undo whitespace change.
mrek-msft 1d405d1
cleanup
mrek-msft b4657db
Improving comments
mrek-msft 1a6955b
Fix wrong direction of searching for bit in bitmask.
mrek-msft 977f60e
Improve comments as proposed by Copilot
mrek-msft e7fa07e
Explicitely handle negative max baudrate
mrek-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.