Add support for JumpStubStubManager when FEATURE_JIT is enabled #121338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
kotlarmilos
added
area-VM-coreclr
os-ios
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR conditionally compiles JumpStubStubManager only when FEATURE_JIT is defined. The change addresses build issues where JumpStubStubManager was referenced in non-JIT configurations where it shouldn't exist.
Key Changes:
- Guards
JumpStubStubManagerclass and related code with#ifdef FEATURE_JITpreprocessor directives - Adds CoreCLR testing for iOS arm64 platform in CI pipeline
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/coreclr/vm/stubmgr.cpp | Wraps JumpStubStubManager::DoEnumMemoryRegions method with FEATURE_JIT guard |
| src/coreclr/inc/vptr_list.h | Conditionally includes JumpStubStubManager vtable entry only when JIT is enabled |
| src/coreclr/inc/dacvars.h | Guards DAC variable definition for JumpStubStubManager with FEATURE_JIT |
| src/coreclr/debug/daccess/daccess.cpp | Wraps usage of JumpStubStubManager::g_pManager in debug access code with FEATURE_JIT |
| eng/pipelines/runtime.yml | Adds new iOS arm64 CoreCLR build and test job to the CI pipeline |
AaronRobinsonMSFT
approved these changes
Nov 4, 2025
This was referenced Nov 4, 2025
Open
Member
Author
|
/ba-g Android queue timeouts dotnet/dnceng#3008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the iOS build by wrapping JumpStubStubManager in FEATURE_JIT. It unblocks dotnet/dotnet#3175 and adds the iOS CoreCLR functional test to runtime.yml to catch build failures earlier in PRs.