Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Fixes #121310

Copilot AI review requested due to automatic review settings November 3, 2025 22:39
@jkoritzinsky jkoritzinsky requested a review from jkotas November 3, 2025 22:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the calculation of symbol range sizes in the ObjectWriter to include the size of the end symbol. Previously, the range size was calculated as the difference between start and end symbol positions (endSymbol.Value - startSymbol.Value), which only included bytes up to the beginning of the end symbol. The fix adds endSymbol.Size to ensure the entire range, including all bytes of the end symbol, is encompassed.

Key changes:

  • Corrects symbol range size calculation to be inclusive of the end symbol's content

@jkoritzinsky
Copy link
Member Author

/ba-g timeouts unrelated

@jkoritzinsky jkoritzinsky enabled auto-merge (squash) November 4, 2025 04:50
@jkoritzinsky jkoritzinsky merged commit 4defc8b into dotnet:main Nov 4, 2025
96 of 104 checks passed
@jkoritzinsky jkoritzinsky deleted the symbol-range-fix branch November 4, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GC Stress failure: Assert failure(PID 3732 [0x00000e94], Thread: 2904 [0x0b58]): curOffset <= infoPtr->methodSize

2 participants