Skip to content

Conversation

@SwapnilGaikwad
Copy link
Contributor

Fixes #120031

Previously, we fixed incorrectly treating offsets as indices (#119853).
This patch fixes the tests for the FirstFaulting gathers that were missed earlier.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Oct 1, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 1, 2025
@SwapnilGaikwad
Copy link
Contributor Author

@dotnet/arm64-contrib @a74nh @EgorBo

@SwapnilGaikwad
Copy link
Contributor Author

SwapnilGaikwad commented Oct 1, 2025

Test failure seems unrelated to the change. This is arm64 change so x64 shouldn't be affected.

@SwapnilGaikwad SwapnilGaikwad added arm-sve Work related to arm64 SVE/SVE2 support and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Oct 2, 2025
@SwapnilGaikwad
Copy link
Contributor Author

Hi @EgorBo, should we merge this? It will then unblock #118380.

@EgorBo
Copy link
Member

EgorBo commented Oct 8, 2025

Hi @EgorBo, should we merge this? It will then unblock #118380.

Sorry, I left it in an open state in case if somebody else has any feedback, looks like not, let me merge now!

@EgorBo EgorBo merged commit 5e61af4 into dotnet:main Oct 8, 2025
77 of 79 checks passed
@SwapnilGaikwad SwapnilGaikwad deleted the github-fix-firstFaultingGathers-120031 branch October 9, 2025 09:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2025
@AndyAyersMS
Copy link
Member

/backport to release/10.0

@github-actions github-actions bot unlocked this conversation Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Started backporting to release/10.0 (link to workflow run)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arm-sve Work related to arm64 SVE/SVE2 support community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: _Sve_ro::JIT.HardwareIntrinsics.Arm._Sve.Program.Sve_GatherVectorInt16WithByteOffsetsSignExtendFirstFaulting_offsets_uint_int()

3 participants