Skip to content

Fix minidump generation - check if IsIL before calling methods related to it #116391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 9, 2025
Merged

Fix minidump generation - check if IsIL before calling methods related to it #116391

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45f7fba
Only get the il from PE if it's not nDirect
thaystg Jun 6, 2025
c08d88b
Fixing like JanK suggested
thaystg Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/coreclr/vm/method.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ COR_ILMETHOD* MethodDesc::GetILHeader()
// Always pickup overrides like reflection emit, EnC, etc.
Copy link
Member

@jkotas jkotas Jun 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notice that this method has a PRECONDITION(IsIL()). It means that it is not expected to be called on IsNDirect method in the first place.

I think the correct fix is to add if (IsIL()) check around the whole CodeVersionManager related block in MethodDesc::EnumMemoryRegions.

TADDR pIL = pModule->GetDynamicIL(GetMemberDef());

if (pIL == (TADDR)NULL)
if (pIL == (TADDR)NULL && !IsNDirect())
{
pIL = pModule->GetIL(GetRVA());
}
Expand Down
Loading