Skip to content

Conversation

@jkoritzinsky
Copy link
Member

Fixes failures in source-build in dotnet/sdk#43015

…e (prerelease or otherwise)

Fixes failures in source-build in dotnet/sdk#43015
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@jkoritzinsky jkoritzinsky merged commit 2cbc23a into dotnet:main Oct 17, 2024
88 checks passed
@jkoritzinsky jkoritzinsky deleted the cdac-build-tool-rollforward branch October 17, 2024 17:44
@MichalStrehovsky
Copy link
Member

This fixed the cdac-build tool, but dotnet/sdk#43015 is now failing with the same thing on crossgen:

      /vmr/src/runtime/dotnet.sh /vmr/src/runtime/artifacts/bin/coreclr/linux.x64.Release/x64/crossgen2/crossgen2.dll -o:/vmr/src/runtime/artifacts/bin/coreclr/linux.x64.Release/System.Private.CoreLib.dll -r:/vmr/src/runtime/artifacts/bin/coreclr/linux.x64.Release/IL/*.dll --targetarch:x64 --targetos:linux -m:/vmr/src/runtime/artifacts/bin/coreclr/linux.x64.Release/StandardOptimizationData.mibc --embed-pgo-data -O /vmr/src/runtime/artifacts/bin/coreclr/linux.x64.Release/IL/System.Private.CoreLib.dll --perfmap-format-version:1 --perfmap --perfmap-path:/vmr/src/runtime/artifacts/bin/coreclr/linux.x64.Release/
      You must install or update .NET to run this application.
      
      App: /vmr/src/runtime/artifacts/bin/coreclr/linux.x64.Release/x64/crossgen2/crossgen2.dll
      Architecture: x64
      Framework: 'Microsoft.NETCore.App', version '9.0.0-preview.7.24405.7' (x64)
      .NET location: /vmr/.dotnet/
      
      The following frameworks were found:
        10.0.0-alpha.1.24504.10 at [/vmr/.dotnet/shared/Microsoft.NETCore.App]

Of course I could go add --rollforward to this crossegen invocation, but I already see we then need to merge IBC files that will likely also run into this problem.

Is there some other mechanism we could use? For example an environment variable we could just set in build.cmd/build.sh? If there is, any drawbacks with that?

@jkoritzinsky
Copy link
Member Author

If we update dotnet-runtime to use a .NET 10 alpha SDK and bump the "Tool current" TFM, that would also work.

I don't think we want to set the environment variable to roll forward automatically as it would allow us to forget to update the target TFM and end up running in an unexpected scenario.

jkotas added a commit to jkotas/runtime that referenced this pull request Oct 27, 2024
Fixes failures in source-build in dotnet/sdk#43015. Same fix was applied to cdac tool in dotnet#108946
ViktorHofer added a commit that referenced this pull request Oct 29, 2024
…available (prerelease or otherwise) (#108946)"

This reverts commit 2cbc23a.
ViktorHofer added a commit that referenced this pull request Oct 30, 2024
* Forward NetCoreAppToolCurrent in DotNetBuild.props

* Update DotNetBuild.props

* Revert "Allow the cdac build tool to roll forward to whatever SDK is available (prerelease or otherwise) (#108946)"

This reverts commit 2cbc23a.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants