Remove unused custom marshaler code and move ICustomMarshaler and Color marshalling handling to managed code by jkoritzinsky · Pull Request #106735 · dotnet/runtime

Commits on Aug 19, 2024

Remove unused "shared custom marshaler helper" code
jkoritzinsky
committed
Collapse together the custom marshaller helper types
jkoritzinsky
committed
Remove CustomMarshalerHelper abstraction
jkoritzinsky
committed
ICustomMarshaler will never support by-value marshalling, so remove the checks outside of the exception path.
jkoritzinsky
committed
Remove native size local as we always set it to the same thing
jkoritzinsky
committed
Remove unused methods
jkoritzinsky
committed
Remove more unused code
jkoritzinsky
committed
Use the same helpers in CustomMarshalerInfo as the IL stubs use
jkoritzinsky
committed
The only method we look up is GetInstance, so clean that up
jkoritzinsky
committed
Move ICustomMarshaler method invocation into the only usage location in the runtime
jkoritzinsky
committed
Remove CustomMarshalerInfo abstraction from P/Invoke IL stubs (inline the indirection into the stub helper)
jkoritzinsky
committed
Change default deep copy option to the one we use in the one case we insert
jkoritzinsky
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove unused custom marshaler code and move ICustomMarshaler and Color marshalling handling to managed code#106735

Remove unused custom marshaler code and move ICustomMarshaler and Color marshalling handling to managed code#106735
jkoritzinsky merged 28 commits intodotnet:mainfrom
jkoritzinsky:cm-cleanup

Commits on Aug 19, 2024

Remove unused "shared custom marshaler helper" code

Collapse together the custom marshaller helper types

Remove CustomMarshalerHelper abstraction

ICustomMarshaler will never support by-value marshalling, so remove the checks outside of the exception path.

Remove native size local as we always set it to the same thing

Remove unused methods

Remove more unused code

Use the same helpers in CustomMarshalerInfo as the IL stubs use

The only method we look up is GetInstance, so clean that up

Move ICustomMarshaler method invocation into the only usage location in the runtime

Remove CustomMarshalerInfo abstraction from P/Invoke IL stubs (inline the indirection into the stub helper)

Change default deep copy option to the one we use in the one case we insert

Commits on Aug 20, 2024

Move IEnumerator marshaller support up to managed code only

Move reflection lookup and handling for Color marshalling to managed code as much as possible.

Fix tests

Fix contract

Fix non-Windows build

Remove unused variable

Commits on Aug 21, 2024

Fix GC mode for getting the custom marshaler object

Commits on Aug 23, 2024

PR feedback

Remove unmanaged definition of System.Drawing.Color from the runtime and remove a box->unbox->box operation sequence

Merge branch 'main' of github.com:dotnet/runtime into cm-cleanup

Remove the QCall and just call ColorMarshaler directly.

Commits on Aug 28, 2024

Merge branch 'main' of https://github.com/dotnet/runtime into cm-cleanup

PR feedback

Fix naming

Update contract

Fix type for ComVariant.Create call and remove unused qcall

Remove unused custom marshaler code and move ICustomMarshaler and Color marshalling handling to managed code#106735jkoritzinsky merged 28 commits intodotnet:maindotnet/runtime:mainfrom jkoritzinsky:cm-cleanupjkoritzinsky/runtime:cm-cleanupCopy head branch name to clipboard

Commits

Commits on Aug 19, 2024

Commits on Aug 20, 2024

Commits on Aug 21, 2024

Commits on Aug 23, 2024

Commits on Aug 28, 2024

Remove unused custom marshaler code and move ICustomMarshaler and Color marshalling handling to managed code#106735
jkoritzinsky merged 28 commits intodotnet:mainfrom
jkoritzinsky:cm-cleanup