Skip to content

[wasi] Select mono components #100407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 18, 2024
Merged

[wasi] Select mono components #100407

merged 11 commits into from
Apr 18, 2024

Conversation

@maraf
Copy link
Member

@maraf maraf commented Mar 28, 2024 •
edited
Loading

  • Never link with diagnostics_tracing
  • Use stubs for debugger and hot_reload for publish, use real components for build (aligns with browser debugger support)
    • Overridable by explicitly setting WasmDebugLevel=1 or 0

Contributes to #96862

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm labels Mar 28, 2024
@maraf maraf added this to the 9.0.0 milestone Mar 28, 2024
@maraf maraf self-assigned this Mar 28, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-service bot commented Mar 28, 2024

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf
Copy link
Member Author

maraf commented Mar 28, 2024

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Mar 28, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Mar 28, 2024
Closed
@maraf
Revert "Don't link icu for InvariantGlobalization=true"
40c49e9 
This reverts commit d62a165.

# Conflicts:
#	src/mono/wasi/build/WasiApp.targets
@maraf
Copy link
Member Author

maraf commented Apr 2, 2024

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 2, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 2, 2024
Open
@lewing lewing requested a review from lambdageek April 3, 2024 21:48
@maraf maraf marked this pull request as ready for review April 4, 2024 10:23
@maraf maraf requested a review from akoeplinger as a code owner April 4, 2024 10:23
@maraf maraf requested a review from lewing April 4, 2024 10:23
@build-analysis build-analysis bot mentioned this pull request Apr 4, 2024
Closed
@maraf

This comment was marked as resolved.

Sign in to view
@maraf

This comment was marked as resolved.

Sign in to view
@maraf maraf marked this pull request as draft April 8, 2024 10:57
@maraf
Copy link
Member Author

maraf commented Apr 8, 2024

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Apr 8, 2024

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 8, 2024

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 8, 2024
Closed
Closed
Closed
Closed
@maraf
Copy link
Member Author

maraf commented Apr 9, 2024 •
edited
Loading

src/mono/wasi/build/WasiApp.targets(264,11): error MSB4057: (NETCORE_ENGINEERING_TELEMETRY=Build) The target "_MonoSelectRuntimeComponents" does not exist in the project.

Seems like MonoTargets are not packed for lib tests.. Okay, wasi lib tests are running without workload, and so mono targets are not there

@maraf
Copy link
Member Author

maraf commented Apr 10, 2024

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 10, 2024

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 10, 2024
Closed
Closed
@maraf
Copy link
Member Author

maraf commented Apr 10, 2024

/azp run runtime-wasm

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 10, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@maraf
Copy link
Member Author

maraf commented Apr 10, 2024

/azp run runtime

@azure-pipelines
Copy link

azure-pipelines bot commented Apr 10, 2024

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 10, 2024
Closed
@maraf maraf marked this pull request as ready for review April 11, 2024 13:43
lewing
lewing reviewed Apr 18, 2024
View reviewed changes
@lewing lewing merged commit b194416 into dotnet:main Apr 18, 2024
@maraf maraf deleted the WasiLinkComponents branch April 18, 2024 19:24
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@maraf @matouskozak
[wasi] Select mono components (dotnet#100407)
6b666fa 
* Don't link icu for InvariantGlobalization=true

* Don't link debugger for publish

* Revert "Don't link icu for InvariantGlobalization=true"

This reverts commit d62a165.

# Conflicts:
#	src/mono/wasi/build/WasiApp.targets

* Drop in-tree setup. Solve the rest of the components

* Incorporate WasmDebugLevel

* Hook MonoSelectRuntimeComponents. Unify component selection

* Fix merge damage

* Conditional mono targets
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@akoeplinger akoeplinger Awaiting requested review from akoeplinger akoeplinger is a code owner

Assignees

@maraf maraf

Labels

arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@maraf @lewing