Skip to content

Conversation

@github-actions
Copy link
Contributor

Backport of #100143 to release/9.0-preview3

/cc @lewing @EgorBo

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 22, 2024
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Mar 22, 2024

Have we verified that this change is actually fixing the issue?

@lewing
Copy link
Member

lewing commented Mar 22, 2024

Have we verified that this change is actually fixing the issue?

Nope. we're waiting to hear from Rolf from main, I opened the backport just to make the potential need clear while they test.

@jkotas
Copy link
Member

jkotas commented Mar 23, 2024

It is no longer crashing in the xamarin-macios codeflow PR: dotnet/macios#20343 .

@EgorBo
Copy link
Member

EgorBo commented Mar 24, 2024

Filed a proper fix #100206, so I presume we should backport that one, although, this revert is also fine to merge since it fixes the problem too (validated)

@dkurepa
Copy link
Member

dkurepa commented Mar 25, 2024

looks like we want to close this PR?

@EgorBo
Copy link
Member

EgorBo commented Mar 26, 2024

looks like we want to close this PR?

Like I said - it's ok to merge this if the issue is blocking.
The PR exposed an existing bug so this revert brings back previous behavior, while we're working on a proper fix.

@lewing lewing closed this Mar 28, 2024
@jkotas jkotas deleted the backport/pr-100143-to-release/9.0-preview3 branch March 31, 2024 15:28
@lewing lewing restored the backport/pr-100143-to-release/9.0-preview3 branch April 9, 2024 18:42
@lewing lewing reopened this Apr 9, 2024
@lewing lewing closed this Apr 9, 2024
@lewing lewing deleted the backport/pr-100143-to-release/9.0-preview3 branch April 9, 2024 18:42
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants