Microsoft.Extensions.Logging.Generators.Tests hardcode the AssemblyVersion

[ViktorHofer]

The generated logging generator baseline files all hardcode the generator's assembly version, i.e.:

runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Baselines/TestWithTwoParams.generated.txt

Line 8 in 6d5a772

[global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.Extensions.Logging.Generators", "6.0.0.0")]

This makes reving the repository to the next major version (including tfm and assembly version) harder as it needs to be, as the test files need to be updated whenever assembly versions change.

@maryamariyan can you please look into this so that we can avoid the hardcoded version?

Failed in #58011.

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The generated logging generator baseline files all hardcode the generator's assembly version, i.e.:

runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Baselines/TestWithTwoParams.generated.txt

Line 8 in 6d5a772

[global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.Extensions.Logging.Generators", "6.0.0.0")]

.

This makes reving the repository to the next major version (including tfm and assembly version) hard as the test files need to updated with it.

@maryamariyan can you please look into this so that we can avoid the hardcoded version?

Failed in #58011.

Author:	ViktorHofer
Assignees:	-
Labels:	area-Infrastructure-libraries, untriaged
Milestone:	-

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

The generated logging generator baseline files all hardcode the generator's assembly version, i.e.:

runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Baselines/TestWithTwoParams.generated.txt

Line 8 in 6d5a772

[global::System.CodeDom.Compiler.GeneratedCodeAttribute("Microsoft.Extensions.Logging.Generators", "6.0.0.0")]

.

This makes reving the repository to the next major version (including tfm and assembly version) hard as the test files need to updated with it

@maryamariyan can you please look into this so that we can avoid the hardcoded version?

Failed in #58011.

Author:	ViktorHofer
Assignees:	-
Labels:	untriaged, area-Extensions-Logging
Milestone:	-

[maryamariyan]

@ViktorHofer what's your recommendation for the fix here?

[sharwell]

• When generating *.generated.txt files, replace the current version number (6.0.0.0 above) with a literal like %VERSION%
• When reading *.generated.txt files, replace %VERSION% with the effective version of the source generator assembly

[ViktorHofer]

Exactly what Sam said. Use replacement tokens instead of the hardcoded versions.

[allantargino]

I would like to take this one :)