Symbols for crossgen2 are not indexed

[davidwrighton]

Description

Debugging crossgen2 binaries that have been shipped is unnecessarily difficult as symbols for crossgen2 specific binaries are not indexed.

The pkgproj that produces the crossgen2 image should have lines like:
<FilesToPackage Include="<PDB item transformation>" IsSymbolFile="true" TargetPath="tools/" /> in it for the crossgen2 unique files.

Running a command like
dotnet-symbol --symbols -o c:\temp\syms C:\Users\david\.nuget\packages\microsoft.netcore.app.crossgen2.win-x64\6.0.0-preview.7.21377.19\tools\*.dll

produces errors like...

Writing: c:\temp\syms\clretwrc.pdb
Writing: c:\temp\syms\clrjit.pdb
ERROR: Not Found: clrjit_unix_arm64_x64.pdb - 'http://msdl.microsoft.com/download/symbols/clrjit_unix_arm64_x64.pdb/0c119ee206b64b99bf8b18397cabf8211/clrjit_unix_arm64_x64.pdb'
ERROR: Not Found: clrjit_unix_arm_x64.pdb - 'http://msdl.microsoft.com/download/symbols/clrjit_unix_arm_x64.pdb/b95d8356a7fa410aa2cb537b846741b71/clrjit_unix_arm_x64.pdb'
ERROR: Not Found: clrjit_unix_osx_arm64_x64.pdb - 'http://msdl.microsoft.com/download/symbols/clrjit_unix_osx_arm64_x64.pdb/a15dbcc42a55439f9c911ca5900eb12d1/clrjit_unix_osx_arm64_x64.pdb'
ERROR: Not Found: clrjit_unix_x64_x64.pdb - 'http://msdl.microsoft.com/download/symbols/clrjit_unix_x64_x64.pdb/d8ed4a6272c84f278df785046e9822041/clrjit_unix_x64_x64.pdb'
ERROR: Not Found: clrjit_win_arm64_x64.pdb - 'http://msdl.microsoft.com/download/symbols/clrjit_win_arm64_x64.pdb/7ebee81dcc4243f296c8c5a17e0c3efa1/clrjit_win_arm64_x64.pdb'
ERROR: Not Found: clrjit_win_arm_x64.pdb - 'http://msdl.microsoft.com/download/symbols/clrjit_win_arm_x64.pdb/2cc06f6b86624dd0bc37cbed64f1ef101/clrjit_win_arm_x64.pdb'
ERROR: Not Found: clrjit_win_x86_x64.pdb - 'http://msdl.microsoft.com/download/symbols/clrjit_win_x86_x64.pdb/61e16843c2dd46be9ec82d49556482e21/clrjit_win_x86_x64.pdb'
Writing: c:\temp\syms\coreclr.pdb
Writing: c:\temp\syms\crossgen2.ni.pdb
ERROR: Not Found: crossgen2.pdb - 'http://msdl.microsoft.com/download/symbols/crossgen2.pdb/51752cd3d3264101bf689c8ffeb8ef8dFFFFFFFF/crossgen2.pdb'
Writing: c:\temp\syms\dbgshim.pdb
Writing: c:\temp\syms\hostfxr.pdb
Writing: c:\temp\syms\hostpolicy.pdb
Writing: c:\temp\syms\ILCompiler.DependencyAnalysisFramework.ni.pdb
ERROR: Not Found: ILCompiler.DependencyAnalysisFramework.pdb - 'http://msdl.microsoft.com/download/symbols/ilcompiler.dependencyanalysisframework.pdb/482f8d449bbc444b9f98771a5cd6ceb0FFFFFFFF/ilcompiler.dependencyanalysisframework.pdb'
Writing: c:\temp\syms\ILCompiler.Diagnostics.ni.pdb
ERROR: Not Found: ILCompiler.Diagnostics.pdb - 'http://msdl.microsoft.com/download/symbols/ilcompiler.diagnostics.pdb/3a9979662320460f89306fa8a6d95dafFFFFFFFF/ilcompiler.diagnostics.pdb'
Writing: c:\temp\syms\ILCompiler.ReadyToRun.ni.pdb
ERROR: Not Found: ILCompiler.ReadyToRun.pdb - 'http://msdl.microsoft.com/download/symbols/ilcompiler.readytorun.pdb/e1040066544c49a2a8a830cc8af49dc2FFFFFFFF/ilcompiler.readytorun.pdb'
Writing: c:\temp\syms\ILCompiler.TypeSystem.ReadyToRun.ni.pdb
Writing: c:\temp\syms\ILCompiler.TypeSystem.ReadyToRun.pdb
ERROR: Not Found: jitinterface_x64.pdb - 'http://msdl.microsoft.com/download/symbols/jitinterface_x64.pdb/b8ab9b650b2a410ea0cd70fe873306871/jitinterface_x64.pdb'
Writing: c:\temp\syms\Microsoft.CSharp.ni.pdb
Writing: c:\temp\syms\Microsoft.CSharp.pdb
Writing: c:\temp\syms\Microsoft.DiaSymReader.ni.pdb

Configuration

Both Windows and Linux

Regression?

No

Other information

[davidwrighton]

@mangod9 we need to assign someone to figure this out. The general expected change we need is to fill the symbol packages with the pdbs, which hopefully the suggested change above should do.

[mangod9]

assume this is a blocker for 6?

[davidwrighton]

Yes. And if we can, we should try to get the fix into RC1 in case we get customer bug reports.

[AntonLapounov]

I am trying David's suggestion above.

[AntonLapounov]

Hmm, when I build the main branch locally with no changes, Microsoft.NETCore.App.Crossgen2.win-x64.7.0.0-dev.symbols.nupkg does contain these PDB files:

crossgen2.pdb
ILCompiler.DependencyAnalysisFramework.pdb
ILCompiler.Diagnostics.pdb
ILCompiler.ReadyToRun.pdb
ILCompiler.TypeSystem.ReadyToRun.pdb

However, they are missing in 6.0.0-preview.7.21377.19. I'll try building release/6.0.

Update: If you do a clean single-step build of the repo, the PDB files above are not included in the symbols package because they have been moved to the PDB directory by

runtime/src/coreclr/Directory.Build.targets

Lines 15 to 16 in e0ebe9e

	<Move SourceFiles="@(BuiltBinary -> '%(RootDir)%(Directory)%(Filename).pdb')"
	DestinationFolder="$(RuntimeBinDir)PDB" />

and cannot be found under the original location. However, if you build the repo incrementally, those PDB files are not moved the second time and are included in the package.