Crosscompile for FreeBSD produce wrongly named ILAsm, ILDAsm, TestHost and native.System.IO.Ports nupkg's

[sec]

Description

While doing crosscompile for FreeBSD, under Linux, using command:

docker run -e ROOTFS_DIR=/crossrootfs/x64 -v $(pwd)/runtime:/runtime $DOTNET_DOCKER_TAG /runtime/eng/build.sh -c Debug -cross -os freebsd -ci /p:OfficialBuildId=$(date +%Y%m%d)-99 /p:IsEligibleForNgenOptimization=false

Runtime is created, but 4 nupkg are wrongly named:

runtime.linux-x64.Microsoft.NETCore.ILAsm.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.Microsoft.NETCore.ILDAsm.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.Microsoft.NETCore.TestHost.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.runtime.native.System.IO.Ports.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.runtime.native.System.IO.Ports.6.0.0-preview.5.21301.5.symbols.nupkg

Other are named correctly:

Microsoft.NETCore.App.Host.freebsd-x64.6.0.0-preview.5.21301.5.nupkg
Microsoft.NETCore.App.Host.freebsd-x64.6.0.0-preview.5.21301.5.symbols.nupkg
Microsoft.NETCore.App.Runtime.freebsd-x64.6.0.0-preview.5.21301.5.nupkg
Microsoft.NETCore.App.Runtime.freebsd-x64.6.0.0-preview.5.21301.5.symbols.nupkg
dotnet-apphost-pack-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-hostfxr-internal-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-composite-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-internal-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-internal-composite-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-targeting-pack-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
runtime.freebsd-x64.Microsoft.NETCore.DotNetAppHost.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetAppHost.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHost.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHost.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostResolver.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostResolver.6.0.0-preview.5.21301.5.symbols.nupkg

Checking inside they contain native FreeBSD binaries which after changing names (and files inside) from linux to freebsd, repacking them, etc. produde fully working SDK which can compile nativly on FreeBSD (big discussion is in #14537

So it looks like, those are only wrongly named, even they are crosscompiled for FreeBSD.

Configuration

Tag tested HEAD detached at v6.0.0-preview.5.21301.5
Host was Ubuntu 20.04

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

While doing crosscompile for FreeBSD, under Linux, using command:

docker run -e ROOTFS_DIR=/crossrootfs/x64 -v $(pwd)/runtime:/runtime $DOTNET_DOCKER_TAG /runtime/eng/build.sh -c Debug -cross -os freebsd -ci /p:OfficialBuildId=$(date +%Y%m%d)-99 /p:IsEligibleForNgenOptimization=false

Runtime is created, but 4 nupkg are wrongly named:

runtime.linux-x64.Microsoft.NETCore.ILAsm.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.Microsoft.NETCore.ILDAsm.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.Microsoft.NETCore.TestHost.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.runtime.native.System.IO.Ports.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.runtime.native.System.IO.Ports.6.0.0-preview.5.21301.5.symbols.nupkg

Other are named correctly:

Microsoft.NETCore.App.Host.freebsd-x64.6.0.0-preview.5.21301.5.nupkg
Microsoft.NETCore.App.Host.freebsd-x64.6.0.0-preview.5.21301.5.symbols.nupkg
Microsoft.NETCore.App.Runtime.freebsd-x64.6.0.0-preview.5.21301.5.nupkg
Microsoft.NETCore.App.Runtime.freebsd-x64.6.0.0-preview.5.21301.5.symbols.nupkg
dotnet-apphost-pack-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-hostfxr-internal-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-composite-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-internal-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-internal-composite-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-targeting-pack-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
runtime.freebsd-x64.Microsoft.NETCore.DotNetAppHost.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetAppHost.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHost.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHost.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostResolver.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostResolver.6.0.0-preview.5.21301.5.symbols.nupkg

Checking inside they contain native FreeBSD binaries which after changing names (and files inside) from linux to freebsd, repacking them, etc. produde fully working SDK which can compile nativly on FreeBSD (big discussion is in #14537

So it looks like, those are only wrongly named, even they are crosscompiled for FreeBSD.

Configuration

Tag tested HEAD detached at v6.0.0-preview.5.21301.5
Host was Ubuntu 20.04

Author:	sec
Assignees:	-
Labels:	area-Infrastructure-coreclr, untriaged
Milestone:	-

[am11]

This was a useful piece of info, thanks for pointing it out at the perfect time! 😉
It will be fixed by current state of #54914 + commit from #54914 (comment).

I have tested it with the latest FreeBSD and Alpine Linux arm64 cross-compile docker tags when making that commit, and it builds all the nupkg files with correct names under artifacts/packages, without needing to explicitly pass /p:OutputRid=... on command line as we have in Auzre Pipeline .yml files.

cc @ViktorHofer, @ericstj

ps - after #54914 is completed and merged, I think we should consider renaming PackageRID to RestorePackageRID and OutputRid to ShippingPackageRID to make it self-explanatory and avoid any future confusions / mishaps.

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

While doing crosscompile for FreeBSD, under Linux, using command:

docker run -e ROOTFS_DIR=/crossrootfs/x64 -v $(pwd)/runtime:/runtime $DOTNET_DOCKER_TAG /runtime/eng/build.sh -c Debug -cross -os freebsd -ci /p:OfficialBuildId=$(date +%Y%m%d)-99 /p:IsEligibleForNgenOptimization=false

Runtime is created, but 4 nupkg are wrongly named:

runtime.linux-x64.Microsoft.NETCore.ILAsm.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.Microsoft.NETCore.ILDAsm.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.Microsoft.NETCore.TestHost.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.runtime.native.System.IO.Ports.6.0.0-preview.5.21301.5.nupkg
runtime.linux-x64.runtime.native.System.IO.Ports.6.0.0-preview.5.21301.5.symbols.nupkg

Other are named correctly:

Microsoft.NETCore.App.Host.freebsd-x64.6.0.0-preview.5.21301.5.nupkg
Microsoft.NETCore.App.Host.freebsd-x64.6.0.0-preview.5.21301.5.symbols.nupkg
Microsoft.NETCore.App.Runtime.freebsd-x64.6.0.0-preview.5.21301.5.nupkg
Microsoft.NETCore.App.Runtime.freebsd-x64.6.0.0-preview.5.21301.5.symbols.nupkg
dotnet-apphost-pack-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-hostfxr-internal-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-composite-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-internal-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-runtime-internal-composite-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
dotnet-targeting-pack-6.0.0-preview.5.21301.5-freebsd-x64.tar.gz
runtime.freebsd-x64.Microsoft.NETCore.DotNetAppHost.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetAppHost.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHost.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHost.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostPolicy.6.0.0-preview.5.21301.5.symbols.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostResolver.6.0.0-preview.5.21301.5.nupkg
runtime.freebsd-x64.Microsoft.NETCore.DotNetHostResolver.6.0.0-preview.5.21301.5.symbols.nupkg

Checking inside they contain native FreeBSD binaries which after changing names (and files inside) from linux to freebsd, repacking them, etc. produde fully working SDK which can compile nativly on FreeBSD (big discussion is in #14537

So it looks like, those are only wrongly named, even they are crosscompiled for FreeBSD.

Configuration

Tag tested HEAD detached at v6.0.0-preview.5.21301.5
Host was Ubuntu 20.04

Author:	sec
Assignees:	ViktorHofer
Labels:	area-Infrastructure
Milestone:	-

[ViktorHofer]

ps - after #54914 is completed and merged, I think we should consider renaming PackageRID to RestorePackageRID and OutputRid to ShippingPackageRID to make it self-explanatory and avoid any future confusions / mishaps.

Would it make sense to follow the Host / Runtime / Target naming schema and use

• TargetRID
• HostRID

instead?

[jkoritzinsky]

I think the split is Build/Host/Target IIRC.

If we do go that route, we need to make sure we stay consistent with the definitions.

[ViktorHofer]

I can't find the thread in which we discussed the nomenclature anymore but aside from that, do we expect people to pass in different values for these properties? If not, we might not want to expose them, prefix them with an underscore and care slightly less about their distinct naming.

[ViktorHofer]

Should be fixed with #54914