.Net 5.0 Application using NAudio libraries crashes without any error message

[TheRealLenon]

Description

Hey Guys,

It seems something on .NET 5 made NAudio (master-branch) crashing without any error message.

There is also an open Issue open on the NAudio´s GitHub.

After discussions i found out, that the runtime tries to access memory it does not own so Windows kills the process with Access Violation.

Configuration

It happens on Windows 20H2 with ANY .NET 5.X.X version.

Related information

Based on the issue from NAudio, it was referred, that .NET Core 3.1 is working. I only could verify it for .NET 5.

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[jackpoz]

Last week I installed Windows Updates and upgraded to Windows 10 21H1 after. I started a .NET 5 application that uses NAudio that worked fine the day before and after the upgrade it closed with Access Violation unhandled exception. Changing the runtime to .Net Core 3.1 fixed the issue.

[TheRealLenon]

Sadly I´m not being able to downgrade to .NET Core 3.1.

But referring to this comment, it is indicating, that there is a bug in the "hotfix" of the current .NET 5.x runtime, which lets the windows kernel kill the application with "Access Violation".

[Zintom]

It would be beneficial if anyone on Windows 20H2 could test this in .NET 5+, that way it would determine if a windows update was involved in the regression.

[TheRealLenon]

It would be beneficial if anyone on Windows 20H2 could test this in .NET 5+, that way it would determine if a windows update was involved in the regression.

I´m currently running 20H2 and couldn´t run it with all .NET 5.x versions. I´ve edited the original message to state this :)

[jackpoz]

I tried on another computer with .NET 5.0.6 and Windows 10 20H2 and it works.
I downloaded .NET 5.0.7 runtime from https://dotnet.microsoft.com/download/dotnet/thank-you/runtime-desktop-5.0.7-windows-x64-installer , started the application and at first I heard random noises and then the application crashed

dotnet --list-runtimes before and working:

dotnet --list-runtimes after and crashing:

So to me this is clearly a 5.0.7 issue not present in 5.0.6

[jkotas]

@jkoritzinsky Can this be regression introduced by #50882 ?

[wzchua]

It works if you published self-contained

[jackpoz]

I created a repro project at https://github.com/jackpoz/NetCore507Crash

Callstack using VS and native debugging enabled:

[jkotas]

https://github.com/jackpoz/NetCore507Crash fails for me with:

C:\NetCore507Crash>C:\NetCore507Crash\bin\Debug\net5.0\NetCore507Crash.exe
Playing some music...
Unhandled exception. System.InvalidOperationException: Buffer full
   at NAudio.Wave.BufferedWaveProvider.AddSamples(Byte[] buffer, Int32 offset, Int32 count)
   at NetCore507Crash.MusicPlayer.Play(String filePath) in C:\NetCore507Crash\Program.cs:line 51
   at NetCore507Crash.Program.Main() in C:\NetCore507Crash\Program.cs:line 20

[KyodaiKen]

To me it really looks like a memory pointer issue. It also is NOT the latest cumulative update. It's one of the .NET security updates. I've uninstalled the 2 latest cumulative updates and it didn't fix it. :/

[jackpoz]

@jkotas I added now a check in case the buffer gets full, I never reached that point in my tests with 5.0.7 as it crashes right away. Please pull latest version.

[jkoritzinsky]

I don't think this is caused by #50882 since that aligned all of the behavior to match .NET Core 3.1, but I guess it's possible that NAudio hits some corner case in it's interop. Without knowing if it even uses LayoutClass marshalling though, I don't know.