Skip to content

[wasm][aot] Don't AOT the helper assemblies for ApplyUpdateTest.StaticMethodBodyUpdate in System.Runtime.Loader tests #53565

@radical

Description

@radical

AOT tracking PR has:

[17:48:49] fail: [FAIL] System.Reflection.Metadata.ApplyUpdateTest.StaticMethodBodyUpdate
[17:48:49] info: Assert.Equal() Failure
[17:48:49] info:           ↓ (pos 0)
[17:48:49] info: Expected: NEW STRING
[17:48:49] info: Actual:   OLD STRING
[17:48:49] info:           ↑ (pos 0)

According to @lambdageek we shouldn't be AOT'ing the assemblies being used by the ApplyUpdateTests(eg. https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime.Loader/tests/System.Runtime.Loader.Tests.csproj#L41)

We would need to set %(WasmASsembliesToBundle._InternalForceInterpret)=true for such assemblies.

Also, would be nice to have a common way of doing this across wasm/iOS/android.

Note: this doesn't fail on main because System.Runtime.Loader.Tests are disabled completely

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions