Test failure: System.Security.Cryptography.X509Certificates.Tests.RevocationTests.AiaTests.DisableAiaOptionWorks

[BruceForstall]

With:

COMPlus_TieredCompilation=0
COMPlus_TailcallStress=1

Fails for Windows x86, x64, and arm64

e.g., (Windows x64, Release libraries, Checked coreclr)

C:\gh\runtime\artifacts\bin\System.Security.Cryptography.X509Certificates.Tests\net5.0-Windows_NT-Release>call .\RunTests.cmd -r C:\gh\runtime\artifacts\bin\testhost\net5.0-Windows_NT-Release-x64
----- start Tue 07/07/2020 11:58:50.12 ===============  To repro directly: =====================================================
pushd C:\gh\runtime\artifacts\bin\System.Security.Cryptography.X509Certificates.Tests\net5.0-Windows_NT-Release\
"C:\gh\runtime\artifacts\bin\testhost\net5.0-Windows_NT-Release-x64\dotnet.exe" exec --runtimeconfig System.Security.Cryptography.X509Certificates.Tests.runtimeconfig.json --depsfile System.Security.Cryptography.X509Certificates.Tests.deps.json xunit.console.dll System.Security.Cryptography.X509Certificates.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
popd
===========================================================================================================

C:\gh\runtime\artifacts\bin\System.Security.Cryptography.X509Certificates.Tests\net5.0-Windows_NT-Release>"C:\gh\runtime\artifacts\bin\testhost\net5.0-Windows_NT-Release-x64\dotnet.exe" exec --runtimeconfig System.Security.Cryptography.X509Certificates.Tests.runtimeconfig.json --depsfile System.Security.Cryptography.X509Certificates.Tests.deps.json xunit.console.dll System.Security.Cryptography.X509Certificates.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing
  Discovering: System.Security.Cryptography.X509Certificates.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Security.Cryptography.X509Certificates.Tests (found 571 of 612 test cases)
  Starting:    System.Security.Cryptography.X509Certificates.Tests (parallel test collections = on, max threads = 8)
    System.Security.Cryptography.X509Certificates.Tests.RevocationTests.AiaTests.DisableAiaOptionWorks [FAIL]
      Chain build with intermediate, AIA disabled
      Expected: True
      Actual:   False
      Stack Trace:
        C:\gh\runtime\src\libraries\System.Security.Cryptography.X509Certificates\tests\RevocationTests\AiaTests.cs(112,0): at System.Security.Cryptography.X509Certificates.Tests.RevocationTests.AiaTests.DisableAiaOptionWorks()
  Finished:    System.Security.Cryptography.X509Certificates.Tests
=== TEST EXECUTION SUMMARY ===
   System.Security.Cryptography.X509Certificates.Tests  Total: 1044, Errors: 0, Failed: 1, Skipped: 0, Time: 10.181s
----- end Tue 07/07/2020 11:59:07.11 ----- exit code 1 ----------------------------------------------------------

category:correctness
theme:tail-call
skill-level:expert
cost:medium

[erozenfeld]

The bad tail call is here:

runtime/src/libraries/System.Net.HttpListener/src/System/Net/Windows/HttpListener.Windows.cs

Lines 307 to 321 in b39c698

	private void AttachRequestQueueToUrlGroup()
	{
	Debug.Assert(Monitor.IsEntered(_internalLock));
	// Set the association between request queue and url group. After this, requests for registered urls will
	// get delivered to this request queue.
	Interop.HttpApi.HTTP_BINDING_INFO info = default;
	info.Flags = Interop.HttpApi.HTTP_FLAGS.HTTP_PROPERTY_FLAG_PRESENT;
	info.RequestQueueHandle = _currentSession.RequestQueueHandle.DangerousGetHandle();
	IntPtr infoptr = new IntPtr(&info);
	SetUrlGroupProperty(Interop.HttpApi.HTTP_SERVER_PROPERTY.HttpServerBindingProperty,
	infoptr, (uint)Marshal.SizeOf(typeof(Interop.HttpApi.HTTP_BINDING_INFO)));
	}

We are passing a pointer to a local infoptr (points to info) to the call to SetUrlGroupProperty. So it's a tailcallstress issue.