Do not offer 'use pattern matching' when it would change semantics#76404
Merged
CyrusNajmabadi merged 1 commit intodotnet:mainfrom Dec 12, 2024
Merged
Conversation
ghost
added
Area-IDE
untriaged
Comment on lines
-119
to
-121
| // Don't convert if the as is part of a using statement | ||
| // eg using (var x = y as MyObject) { } | ||
| if (localStatement is UsingStatementSyntax) |
Member
There was a problem hiding this comment.
This check for old school using statements is no longer needed because the analyzer is restricted to declarators in a local declaration statement, right?
DustinCampbell
approved these changes
Dec 12, 2024
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Looks good to me! Do you trust my Roslyn reviews though? 😄
Contributor
Author
|
Always :-) |
This was referenced Dec 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39600