Skip to content

Fix extract method in top level#76402

Merged
CyrusNajmabadi merged 12 commits intodotnet:mainfrom
CyrusNajmabadi:extractMethodTopLevel
Dec 12, 2024
Merged

Fix extract method in top level#76402
CyrusNajmabadi merged 12 commits intodotnet:mainfrom
CyrusNajmabadi:extractMethodTopLevel

Conversation

@CyrusNajmabadi
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Dec 12, 2024

Fixes #67647

Followup to #76383

The general idea here is that at the top level:

  1. we should not offer extract method, we should offer 'extract local function' in our lightbulb.
  2. if the user invokes the command handler, we should try 'extract method' first. If that fails, we should try 'extract local function'. If that produces a better outcome, we use that instead.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner December 12, 2024 20:19
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 12, 2024
@CyrusNajmabadi CyrusNajmabadi changed the title Fix wxtract method in top level Fix extract method in top level Dec 12, 2024
@CyrusNajmabadi
Copy link
Contributor Author

@JoeRobich @ToddGrun @akhera99 ptal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extracting method after confirmations does nothing

3 participants