Optimize ProjectDependencyGraph.DoesProjectTransitivelyDependOnProject#76399
Merged
ToddGrun merged 1 commit intodotnet:mainfrom Dec 13, 2024
Conversation
I believe that this method unnecessarilly obtains the reverse dependencies when the forward references are already defined. If the forward references are present, we should just use the result of trying to find the potential dependencies in it. DoesProjectTransitivelyDependOnProject shows as 2.9% of allocations and 1.6% of CPU in the typing scenario in the scharp editing speedometer test. Will kick off a test insertion and see what those numbers are with this change.
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Dec 12, 2024
jasonmalinowski
approved these changes
Dec 12, 2024
Contributor
Author
|
Test Insertion: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/598266 Update: Test insertion numbers didn't improve as much as hoped, but there is a bit of variance in this test that might account for that. I'm going to go ahead and merge, as I think this is a good change. Will take another peek a bit further into this stack to see if anything else sticks out. |
ToddGrun
changed the title
This was referenced Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe that this method unnecessarilly obtains the reverse dependencies when the forward references are already defined. If the forward references are present, we should just use the result of trying to find the potential dependencies in it.
DoesProjectTransitivelyDependOnProject shows as 2.9% of allocations and 1.6% of CPU in the typing scenario in the scharp editing speedometer test. Will kick off a test insertion and see what those numbers are with this change.
*** CPU before change ***
*** Allocations before change ***
