Skip to content

Change PR Val builds to be unsigned#76358

Merged
JoeRobich merged 6 commits intomainfrom
dev/jorobich/test-sign-prval
Dec 13, 2024
Merged

Change PR Val builds to be unsigned#76358
JoeRobich merged 6 commits intomainfrom
dev/jorobich/test-sign-prval

Conversation

@JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Dec 10, 2024

Disables signing for build artifacts to improve the turn around time for getting results back from a validation run.

Measuring from SignToolTask starting to SignToolTask execution finished.

  • Real signing: varies but is a whole lotta time (could be over an hour)
  • Test signing: ~7min
  • No signing: <1sec

Test Run: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10705817&view=results (microsoft)

@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 10, 2024
@JoeRobich JoeRobich changed the title [WIP] Change PR Val builds to be test signed Change PR Val builds to be unsigned Dec 13, 2024
@JoeRobich JoeRobich marked this pull request as ready for review December 13, 2024 07:39
@JoeRobich JoeRobich requested a review from a team as a code owner December 13, 2024 07:40
Co-authored-by: Jan Jones <[email protected]>
@JoeRobich JoeRobich enabled auto-merge December 13, 2024 16:23
@JoeRobich JoeRobich merged commit 2eca5b2 into main Dec 13, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 13, 2024
@JoeRobich JoeRobich deleted the dev/jorobich/test-sign-prval branch December 20, 2024 18:56
@dibarbet dibarbet modified the milestones: Next, 17.13 P3 Jan 7, 2025
dibarbet added a commit that referenced this pull request Jan 22, 2025
This reverts commit 2eca5b2, reversing
changes made to fe3a243.
dibarbet added a commit that referenced this pull request Jan 23, 2025
Current guess is that this is the cause of the rps/speedometer ngen
failures.
Also the signing variable override doesn't appear to work (variable
already defined in pipeline UI gets overriden to empty. and the msbuild
condition I think should be DotNetSignType)

This reverts commit 2eca5b2, reversing
changes made to fe3a243.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants