feat(lsp): add --pipe parameter#76351
Conversation
|
Hi @JoeRobich I saw you are going to review the PR, are we need some tests for this? Couldn't find any similar tests in the repo. I had also some issues to run the tests on linux machine, are they supposed to work only on windows? Thank you in advance. |
|
@616b2f When you feel good about your PR please mark it as "Ready for review". Thanks!
Taking a look and it appears we would need to do a bit of refactoring here to make this testable. You do not need to do that for this PR.
Unfortunately some of unit tests have dependencies that require Windows as the reuse some VS Editor types. This is something we plan to address as the Language Server needs multi-platform coverage. |
src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
Outdated
Show resolved
Hide resolved
src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Program.cs
Outdated
Show resolved
Hide resolved
…am.cs Co-authored-by: Cyrus Najmabadi <[email protected]>
resolves #72871