Constructor ordering, defaults, and overloads#63371

Merged

Soreloser2 merged 71 commits intodotnet:features/ConvertToRecordfrom

Soreloser2:ConvertToRecordPrs/ConstructorOverloads

Aug 22, 2022

Commits on Jul 5, 2022

WIP on a very simple refactoring
Soren Dahl
committed

Commits on Jul 6, 2022

WIP, refactoring works in simple cases, no tests
Soren Dahl
committed

Commits on Jul 7, 2022

Remove no-interface requirement
Soren Dahl
committed

Commits on Jul 11, 2022

WIP, moving from symbol-based conversion to syntax
Soren Dahl
committed

Commits on Jul 12, 2022

More WIP, mostly working based off of syntax changes
Soren Dahl
committed

Commits on Jul 13, 2022

Merge branch 'main' of https://github.com/dotnet/roslyn into ConvertToRecord
Soren Dahl
committed
Fix a couple bugs
Soren Dahl
committed

Commits on Jul 15, 2022

few refinements and commenting out things for later implementation, added test file
Soren Dahl
committed

Commits on Jul 21, 2022

WIP, Checks Constructor to make sure we can safely delete, doc comments (sort of) working
Soren Dahl
committed

Commits on Jul 26, 2022

Documentation Comment progress, almost done with some spacing bugs for multiline comments
Soren Dahl
committed

Commits on Jul 27, 2022

Finished Documentation comment handling(for now), added tests for attributes and structs
Soren Dahl
committed
Merge branch 'main' of https://github.com/dotnet/roslyn into ConvertToRecord
Soren Dahl
committed
Added features resources
Soren Dahl
committed
Address some feedback
Soren Dahl
committed

Commits on Jul 29, 2022

Addressed some feedback
Soren Dahl
committed
Fixed tests so that we expect a semicolon when no members, fixed comment formatting
Soren Dahl
committed
Added basic inheritance and member modification tests
Soren Dahl
committed
Fixed error and added tests around property accessors
Soren Dahl
committed
Added primary constructo override tests
Soren Dahl
committed
Added more TODO comments
Soren Dahl
committed

Commits on Aug 1, 2022

Renamed test
Soren Dahl
committed

Commits on Aug 3, 2022

WIP addressing feedback
Soren Dahl
committed
More feedback addressing, refactored modified members method
Soren Dahl
committed
Refactoring operation logic, adding tests
Soren Dahl
committed
Small IOperation changes, added test
Soren Dahl
committed
Fixed test failures
Soren Dahl
committed
Moved ShouldConvertProperty, will restructure format
Soren Dahl
committed
Refactored member modifier to use property analysis results
Soren Dahl
committed
WIP Equals analysis
Soren Dahl
committed
Added tests and fixed a couple bugs
Soren Dahl
committed

Commits on Aug 4, 2022

More WIP on Equals method analysis
Soren Dahl
committed
More Equals WIP
Soren Dahl
committed

Commits on Aug 8, 2022

Removed live unit testing file that was accidentally included
Soren Dahl
committed
Addressing feedback:
Soren Dahl
committed
Fixed failing test cleanup
Soren Dahl
committed
Merged initial pr changes
Soren Dahl
committed
WIP fixes:
Soren Dahl
committed

Commits on Aug 10, 2022

Integrate checks for hashcode and equals, refactor to include fields
Soren Dahl
committed
Locked localization of record
Soren Dahl
committed
Fixed bugs, tests all pass
Soren Dahl
committed
Moved static operation analysis helpers into separate class
Soren Dahl
committed
Added abstraction to hashcode and equals to do all checks
Soren Dahl
committed
Added test, extra case for when we have two equals methods
Soren Dahl
committed
Added copy constructor filtering, small bug fixes and changes
Soren Dahl
committed
Fixed small test error
Soren Dahl
committed
Clean up code a bit
Soren Dahl
committed

Commits on Aug 11, 2022

Fixed test errors
Soren Dahl
committed
Merge with feature branch
Soren Dahl
committed
Cleaned up structure of some equals checker methods
Soren Dahl
committed
WIP analyzing constructor for order and defaults
Soren Dahl
committed

Commits on Aug 12, 2022

Added ordering and default tests, fixed bug
Soren Dahl
committed
Added and tested this initializer analysis on non-primary constructors
Soren Dahl
committed

Commits on Aug 16, 2022

Moved helper code to different name, build errors
Soren Dahl
committed
Removed no duplicate requirement from equals and hashcode
Soren Dahl
committed
Refactored equality checking statements method to use recursion instead
Soren Dahl
committed
Refactored HashCode analyzer back into analyzers project, in helpers
Soren Dahl
committed
renamed helper
Soren Dahl
committed
Address feedback, remove IEquatable
Soren Dahl
committed
Fixed leading extra line on first member after member removal
Soren Dahl
committed
Improved IEquatable symbol checking/removal
Soren Dahl
committed

Commits on Aug 17, 2022

Addressing feedback, not done
Soren Dahl
committed

Commits on Aug 18, 2022

Address more PR feedback, reorganize code mostly
Soren Dahl
committed
Use Construct to get correct generic type for IEquatable
Soren Dahl
committed
Fixed nullable warnings
Soren Dahl
committed
Small change
Soren Dahl
committed

Commits on Aug 19, 2022

Merge
Soren Dahl
committed
Fix small build and test issues
Soren Dahl
committed
merge with upstream feature branch
Soren Dahl
committed
Addressed feedback, refactoring and simplifying
Soren Dahl
committed

Commits on Aug 22, 2022

Fix small error in asignment checker and add test
Soren Dahl
committed
Removed null check as it wasn't necessary
Soren Dahl
committed