Update csharp_indent_braces to allow for more fine grained control

[drieseng]

The csharp_indent_braces .editorconfig option currently only allows one to enable or disable indent of braces for all code elements.

Would it be possible to allows indenting of braces to be enabled for specific code elements (just as other options like csharp_new_line_before_open_brace have)?

In our team, we indent braces for object initializers, but not for namespaces, types and methods.
For example:

namespace CodeStyle
{
    public class Program
    {
        var x = new Person
            {
                Name = "John",
                Age = 49
            };
        Console.WriteLine(x.Name);
    }
}

Currently it's not possible to configure this style.
We therefore have to disable IDE0055 (dotnet_diagnostic.IDE0055.severity = none) which is quite a pity as we miss out on other useful formatting checks.

I propose to update csharp_indent_braces to allow for the following values:

• accessors
• anonymous_methods
• anonymous_types
• control_blocks
• events
• indexers
• lambdas
• local_functions
• methods
• object_collection_array_initializers
• properties
• types
• namespaces
• all
• none

For compatibility, the current allowed values true and false can remain supported:

• true can be alias for all that enable braces for all code elements.
• false can be alias for none that disable braces for all code elements.

[drieseng]

@vatsalyaagrawal, is there anything I can do to help? I suppose there are two parts to this issue:

1. Update VS to correctly apply this setting when formatting code.
2. Have an analyzer report any violations (via IDE0055).

[CyrusNajmabadi]

@drieseng we are unlikely to make any changes to our current formatting engine, due to the high risk of regressions and unintended impact on users currently on it. We are currently working on a design for a new formatter (@jmarolf for details) that would ideally allow for more extensibility. We'll add this feature request to that item so it is tracked.

[btzdnl]

Is there any progress here? This one rule basically means IDE0055 must be disabled entirely. Surely that can’t be right?!

Consider this (different language construct from OP):

var hasAllTheInterestingPropertiesSet = someRatherLongVariableName is
    { UnnecessarilyExpressivePropertyNameA: not null, UnnecessarilyExpressivePropertyNameB: not null, YetAnotherProperty: not null, };

With csharp_indent_braces set to false (as is natural with C#), the analyzer considers this “illegal”. Instead, I would have to put the opening brace on the same indent as var. That looks ridiculous IMHO, this is a continuation of a statement, not a new statement. I cannot even get Rider to format it like that.

Now I am forced to disable code formatting analysis entirely, just because csharp_indent_braces is only either true or false.

I see two ways forward that should be reasonably easy to accomplish and will not break things:

• Similar to How to suppress CA1305 warnings for a specific type? roslyn-analyzers#5372, implement a general way to opt out of certain rules
• Make csharp_indent_braces an optional rule by allowing ignore, similar to csharp_space_around_binary_operators