"Add 'DebuggerDisplay' attribute" might not be respecting user preferences

[Youssef1313]

roslyn/src/Features/Core/Portable/AddDebuggerDisplay/AbstractAddDebuggerDisplayCodeRefactoringProvider.cs

Line 164 in 837e83d

returnType: generator.TypeExpression(SpecialType.System_String),

This will always generate string, even if the user prefers String. See #19242.

I think the CSharpSyntaxGenerator.TypeExpression(SpecialType) API is what needs modification here to respect user preferences. Not that we go and use the other overload.

cc @sharwell @CyrusNajmabadi (feel free to change the issue title as appropriate, depending on whether you agree we should modify the TypeExpression method or just fix the refactoring)

[CyrusNajmabadi]

in general, i'd only want us to do anything here if we had actual complaints from users :)

[Youssef1313]

I feel like TypeExpression(ITypeSymbol) and TypeExpression(SpecialType)` should do the same. Esp that they're public APIs. It's not good if I go and refactor some code to call the second overload and find a behavioral change. That's one point of view. The other point of view is "respect user preferences when possible".

If it's decided to keep everything as is, at least both overloads should have doc comment that say whether it respects user preference or not.

[Youssef1313]

Regarding an actual complaint, there was in past a similar one: #19174

[CyrusNajmabadi]

Closing due to lack of feedback.