[main] Update dependencies from dotnet/arcade by dotnet-maestro[bot] · Pull Request #6972 · dotnet/roslyn-analyzers

dotnet-maestro · 2023-10-05T12:09:37Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.DotNet.XliffTasks: from 1.0.0-beta.23426.1 to 1.0.0-beta.23525.5 (parent: Microsoft.DotNet.Arcade.Sdk)

From https://github.com/dotnet/arcade

Subscription: 76dfce4f-6528-42c1-dffb-08d8df7e96ad
Build: 20231031.1
Date Produced: October 31, 2023 7:59:49 AM UTC
Commit: 0ebe09a5ce6665a5fe1df1c644d4f77189c4deba
Branch: refs/heads/main

Updates:
- Microsoft.DotNet.Arcade.Sdk: from 8.0.0-beta.23463.1 to 9.0.0-beta.23531.1

Updates to .NET SDKs:
- Updates sdk.version to 8.0.100-rtm.23506.1
- Updates tools.dotnet to 8.0.100-rtm.23506.1

…004.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk

github-actions

This PR changes the .NET SDK version. Review required from @dotnet/roslyn-infrastructure-current-swat before merging.

…006.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk

…006.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk

…008.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23508.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk

…010.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk

…010.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk

…016.5 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23516.5 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk

…017.7 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23517.7 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23516.1 (parent: Microsoft.DotNet.Arcade.Sdk

…018.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23518.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23516.1 (parent: Microsoft.DotNet.Arcade.Sdk

…024.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23524.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23523.1 (parent: Microsoft.DotNet.Arcade.Sdk

…025.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23525.2 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23523.1 (parent: Microsoft.DotNet.Arcade.Sdk

…027.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23527.1 Dependency coherency updates Microsoft.DotNet.XliffTasks From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23525.5 (parent: Microsoft.DotNet.Arcade.Sdk

…027.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23527.3

…027.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23527.4

…028.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23528.2

ViktorHofer · 2023-10-29T07:01:56Z

+    <Dependency Name="Microsoft.DotNet.XliffTasks" Version="1.0.0-beta.23525.5" CoherentParentDependency="Microsoft.DotNet.Arcade.Sdk">
      <Uri>https://github.com/dotnet/xliff-tasks</Uri>
-      <Sha>194f32828726c3f1f63f79f3dc09b9e99c157b11</Sha>
+      <Sha>0140d3d4a520d602a0721422eb656b78f16b5fba</Sha>
      <SourceBuild RepoName="xliff-tasks" ManagedOnly="true" />
    </Dependency>


@carlossanlop I don't have permissions in this repository. Please update these lines similar to my comment in roslyn: https://github.com/dotnet/roslyn/pull/70597/files#r1375319003

Use the latest version and commit from the Arcade.Sdk entry above.

@Evangelink helped do it before I could. Thanks!

@ViktorHofer there is a blocking review by the bot. What do we do about it?

ViktorHofer · 2023-10-30T16:52:54Z

What I mentioned offline is that we need to update to the Windows build pool that has the VS previews installed.

Evangelink · 2023-10-30T16:56:26Z

Maybe there is also an update to do regarding the coherency bot check.

ViktorHofer · 2023-10-30T18:52:27Z

@carlossanlop / @Evangelink can you please update the windows VS pool in this repo so that we are on 17.8 Preview? Might be this line:

roslyn-analyzers/azure-pipelines.yml

Line 37 in 093570e

demands: ImageOverride -equals windows.vs2022.amd64.open

Evangelink · 2023-10-30T19:04:46Z

I have pushed to use windows.vs2022preview.amd64.open

codecov · 2023-10-30T19:28:09Z

Codecov Report

Merging #6972 (9cf7d38) into main (cf0cf55) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #6972      +/-   ##
==========================================
- Coverage   96.42%   96.42%   -0.01%     
==========================================
  Files        1412     1412              
  Lines      336409   336432      +23     
  Branches    11115    11117       +2     
==========================================
+ Hits       324398   324418      +20     
- Misses       9208     9210       +2     
- Partials     2803     2804       +1

Evangelink · 2023-10-31T12:03:02Z

@mavasani @sharwell It should be good to merge but I'll let you make the call.

…031.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23531.1

Stale

Evangelink · 2023-10-31T13:12:30Z

@mavasani It should be good now :)

mavasani · 2023-10-31T13:47:35Z

@mavasani It should be good now :)

@Evangelink will this take care of #2747 (comment)?

Evangelink · 2023-10-31T13:53:07Z

@mavasani It should be good now :)

@Evangelink will this take care of #2747 (comment)?

Not sure entirely. I tried to git clean and build and I don't have the issue.

ViktorHofer · 2023-10-31T14:36:36Z

Note, the Validate coherency failing leg is a known issue: dotnet/arcade-services#3036

carlossanlop · 2023-10-31T15:59:16Z

Both global.json entries are now pointing to rc2. Merging now.

dotnet-maestro Bot requested a review from a team as a code owner October 5, 2023 12:09

github-actions Bot previously requested changes Oct 5, 2023

View reviewed changes

dotnet-maestro Bot added 26 commits October 6, 2023 12:10

Update dependencies from https://github.com/dotnet/arcade build 20231…

e5ba302

…027.3 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23527.3

Update dependencies from https://github.com/dotnet/arcade build 20231…

f405501

…027.4 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23527.4

Update dependencies from https://github.com/dotnet/arcade build 20231…

4a7661a

…028.2 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23528.2

ViktorHofer reviewed Oct 29, 2023

View reviewed changes

carlossanlop requested a review from ViktorHofer October 30, 2023 16:50

Use preview machine for public CI

685caba

sharwell previously requested changes Oct 30, 2023

View reviewed changes

Comment thread global.json Outdated

Downgrade global.json tools->dotnet to 8.0.100-rc.2.23502.2

3392972

carlossanlop requested a review from sharwell October 30, 2023 20:36

ViktorHofer reviewed Oct 30, 2023

View reviewed changes

Comment thread global.json Outdated

More revert

5f972bf

ViktorHofer approved these changes Oct 31, 2023

View reviewed changes

Evangelink approved these changes Oct 31, 2023

View reviewed changes

Update dependencies from https://github.com/dotnet/arcade build 20231…

85b6c01

…031.1 Microsoft.DotNet.Arcade.Sdk From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23531.1

mavasani enabled auto-merge October 31, 2023 12:08

mavasani disabled auto-merge October 31, 2023 12:09

mavasani reviewed Oct 31, 2023

View reviewed changes

Comment thread global.json Outdated

Revert again to 8.0.100-rc.2.23502.2

9cf7d38

carlossanlop merged commit 36797a8 into main Oct 31, 2023

carlossanlop deleted the darc-main-26b612c3-8f00-4779-b975-ce5ca11f99d5 branch October 31, 2023 15:59

carlossanlop mentioned this pull request Oct 31, 2023

RS0030 Banned type symbol not reported when property/method return type or parameter #2747

Open

Uh oh!

Conversation

dotnet-maestro Bot commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coherency Updates

From https://github.com/dotnet/arcade

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

ViktorHofer Oct 29, 2023

Choose a reason for hiding this comment

Uh oh!

carlossanlop Oct 30, 2023

Choose a reason for hiding this comment

Uh oh!

ViktorHofer commented Oct 30, 2023

Uh oh!

Evangelink commented Oct 30, 2023

Uh oh!

ViktorHofer commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Evangelink commented Oct 30, 2023

Uh oh!

codecov Bot commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Evangelink commented Oct 31, 2023

Uh oh!

Uh oh!

Evangelink commented Oct 31, 2023

Uh oh!

mavasani commented Oct 31, 2023

Uh oh!

Evangelink commented Oct 31, 2023

Uh oh!

ViktorHofer commented Oct 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

carlossanlop commented Oct 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dotnet-maestro Bot commented Oct 5, 2023 •

edited

Loading

ViktorHofer commented Oct 30, 2023 •

edited

Loading

codecov Bot commented Oct 30, 2023 •

edited

Loading

ViktorHofer commented Oct 31, 2023 •

edited

Loading