Handle conversion operation as operands of IThrowOperation#6304
Merged
Conversation
Author
Author
|
@sharwell The github action seems to always label my PRs as |
Member
Youssef1313
reviewed
Dec 8, 2022
Member
I figured that out. The action isn't able to know that you are in dotnet organizations because you set it to private. If you want to make it public, you can set it here. Meanwhile, I think the Action should still be able to handle private members correctly. It probably doesn't because it lacks permissions. I'll open a PR that might fix it. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6304 +/- ##
==========================================
- Coverage 96.07% 96.07% -0.01%
==========================================
Files 1367 1367
Lines 315337 315352 +15
Branches 10187 10187
==========================================
+ Hits 302965 302976 +11
- Misses 9939 9942 +3
- Partials 2433 2434 +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6284
Starting C# 8.0, C# compiler wraps the thrown operation within an implicit conversion to
System.Exceptiontype.