Should the DotNet.ReproducibleBuilds package be an SDK instead?

[MattKotsenas]

The DotNet.ReproducibleBuilds.Isolated package is an SDK, DotNet.ReproducibleBuilds is not. Should they both be?

The specific issue that prompts this issue is that I see devs using properties set by RB like $(ContinuousIntegrationBuild) in Directory.Build.props, but the D.B.props file is imported first per dotnet/msbuild#994 (comment).

Since RB is essentially an extension to the SDK, this feels like a defensible change to me. Open question about how much of a breaking change this would be. We likely could leave a stub .props file behind that emits a warning to explain the upgrade path.

[baronfel]

I think if we did fix this we'd need to do a staged migration - keeping the Sdk.props and Sdk.targets but delegating those to import props and targets from the 'normal' build/DotNet.ReproducibleBuilds.[props|targets] locations so that users can reference it as an SDK or a PackageReference.

Then we could break after enough time for folks to migrate.

[AraHaan]

Yes, I think SDK instead is better.

[sliekens]

@MattKotsenas why not both? See this example in CopyOnWrite

• https://github.com/microsoft/MSBuildSdks/blob/main/src/CopyOnWrite/build/Microsoft.Build.CopyOnWrite.targets
• https://github.com/microsoft/MSBuildSdks/blob/main/src/CopyOnWrite/Sdk/Sdk.targets

They added build targets for use with <PackageReference> and also Sdk targets for use with <Sdk>. This has the added benefit that you can also put the config in Directory.Packages.props (central package management) with <GlobalPackageReference>.

//cc @baronfel @AraHaan

[sliekens]

Personally I prefer the aesthetic of GlobalPackageReference in CPM

<Project>
  <PropertyGroup>
    <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
    <CentralPackageTransitivePinningEnabled>true</CentralPackageTransitivePinningEnabled>
    <NoWarn>$(NoWarn);NU1507</NoWarn>
  </PropertyGroup>
  <ItemGroup>
    <GlobalPackageReference Include="DotNet.ReproducibleBuilds" Version="1.2.39" PrivateAssets="All" />
    <!-- Not supported because it is Sdk:
    <GlobalPackageReference Include="DotNet.ReproducibleBuilds.Isolated" Version="1.2.39" PrivateAssets="All" /> -->
  </ItemGroup>
  <ItemGroup>
    <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
    <PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.0.4" />
    <PackageVersion Include="xunit.runner.visualstudio" Version="3.1.5" />
    <PackageVersion Include="xunit.v3" Version="3.1.0" />
  </ItemGroup>
</Project>

[AraHaan]

I feel like the best place is to insert the DotNet.ReproducibleBuilds package reference into the base .NET SDK itself by default as an implicit reference.