[main] Revert "Map component start tags to C#, for better GTD, FAR, Hover, etc. (#12287) #12486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
approved these changes
Nov 14, 2025
This was referenced Nov 16, 2025
davidwengier
added a commit
that referenced
this pull request
Nov 19, 2025
Fixes #12276 again Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2633418 Commit-at-a-time is thoroughly recommended. Commits 1-4 expose a DocumentExcerpt service that Roslyn can use to provide nice results in FAR etc., because without the code-gen changes, the generated code is pretty ugly. Commit 5 "reverts" #12486, bringing #12287 back but _without_ any changes to the code-gen this time, just a new source mapping. Commit 6 is test baseline updates (only source mappings, no .cs files) Commit 7 removes the requirement for line pragmas to exactly match source mappings. I left the rest of the validation though Commit 8 bumps us to a new Roslyn with the new document excerpt services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12485 to main
/cc @davidwengier
Customer Impact
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]