Skip to content

Conversation

@eiriktsarpalis
Copy link
Member

Adds the first benchmark suite covering System.Numerics.TensorPrimitives. This class only covers generic signed integer APIs. Once we have agreement on the overall structure I will follow up with more PRs extending coverage to the rest of the library.

@DrewScoggins
Copy link
Member

I agree with both @tannergooding and @stephentoub here. In general, small and large values are what we typically end up settling on as that gives us most of the coverage that we need.

cincuranet
cincuranet previously approved these changes Feb 14, 2024
Copy link
Contributor

@cincuranet cincuranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, minus what others already said.

@eiriktsarpalis eiriktsarpalis changed the title Add initial TensorPrimitives benchmarks. Add TensorPrimitives benchmarks. Feb 14, 2024
@eiriktsarpalis
Copy link
Member Author

I've pushed changes adding representative benchmarks for the remainder of the TP APIs. PTAL and let me know if I left out any important routines.

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@eiriktsarpalis
Copy link
Member Author

@cincuranet @DrewScoggins could you help me get this PR merged? Seems like CI errors are unrelated infrastructural issues also impacting main, e.g.

[2024/02/15 02:35:23][INFO] dotnet-install: Attempting to download using primary link https://dotnetcli.azureedge.net/dotnet/Sdk/8.0.201/dotnet-sdk-8.0.201-linux-x64.tar.gz
[2024/02/15 02:35:23][INFO] curl: (22) The requested URL returned error: 404
[2024/02/15 02:35:23][INFO] dotnet-install: The resource at primary link 'https://dotnetcli.azureedge.net/dotnet/Sdk/8.0.201/dotnet-sdk-8.0.201-linux-x64.tar.gz' is not available.
[2024/02/15 02:35:23][INFO] dotnet-install: Attempting to download using primary link https://dotnetbuilds.azureedge.net/public/Sdk/8.0.201/dotnet-sdk-8.0.201-linux-x64.tar.gz
[2024/02/15 02:35:23][INFO] curl: (22) The requested URL returned error: 404
[2024/02/15 02:35:23][INFO] dotnet-install: The resource at primary link 'https://dotnetbuilds.azureedge.net/public/Sdk/8.0.201/dotnet-sdk-8.0.201-linux-x64.tar.gz' is not available.
[2024/02/15 02:35:23][INFO] dotnet_install: Error: Could not find `.NET Core SDK` with version = 8.0.201
[2024/02/15 02:35:23][INFO] dotnet_install: Error: Refer to: https://aka.ms/dotnet-os-lifecycle for information on .NET Core support
[2024/02/15 02:35:23][INFO] $ popd
[2024/02/15 02:35:23][ERROR] Process exited with status 1

@cincuranet
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cincuranet cincuranet disabled auto-merge February 15, 2024 19:01
@cincuranet cincuranet merged commit 41f4350 into dotnet:main Feb 15, 2024
@cincuranet
Copy link
Contributor

Failures are unrelated. Merging.

eiriktsarpalis added a commit that referenced this pull request Feb 19, 2024
Addresses feedback from #3922 (review)
@eiriktsarpalis eiriktsarpalis deleted the tensorprimitives branch February 19, 2024 11:57
cincuranet pushed a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants