-
Notifications
You must be signed in to change notification settings - Fork 285
Add TensorPrimitives benchmarks. #3922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Outdated
Show resolved
Hide resolved
e76e20f to
374cc96
Compare
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Outdated
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Outdated
Show resolved
Hide resolved
|
I agree with both @tannergooding and @stephentoub here. In general, small and large values are what we typically end up settling on as that gives us most of the coverage that we need. |
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Show resolved
Hide resolved
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_SignedIntegerTensorPrimitives.cs
Show resolved
Hide resolved
88325f3 to
288f6e2
Compare
cincuranet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, minus what others already said.
|
I've pushed changes adding representative benchmarks for the remainder of the TP APIs. PTAL and let me know if I left out any important routines. |
stephentoub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
ee08384 to
0abfc87
Compare
0abfc87 to
e216340
Compare
|
@cincuranet @DrewScoggins could you help me get this PR merged? Seems like CI errors are unrelated infrastructural issues also impacting main, e.g. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Failures are unrelated. Merging. |
src/benchmarks/micro/libraries/System.Numerics.Tensors/Perf_NumberTensorPrimitives.cs
Show resolved
Hide resolved
Addresses feedback from #3922 (review)
Addresses feedback from #3922 (review)
Adds the first benchmark suite covering
System.Numerics.TensorPrimitives. This class only covers generic signed integer APIs. Once we have agreement on the overall structure I will follow up with more PRs extending coverage to the rest of the library.