Skip to content

Base64Tests: Use valid input data #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 20, 2022
Merged

Base64Tests: Use valid input data #2479

merged 5 commits into from
Jun 20, 2022

Conversation

@a74nh
Copy link
Contributor

@a74nh a74nh commented Jun 14, 2022

The tests were using random generated chars. This would cause the Decode
functions to exit early (usually after a single iteration).

@a74nh
Base64Tests: Use valid input data
ef88339 
The tests were using random generated chars. This would cause the Decode
functions to exit early (usually after a single iteration).
@a74nh
Copy link
Contributor Author

a74nh commented Jun 14, 2022

Spotted this whilst implementing dotnet/runtime#70654 and dotnet/runtime#70336

@a74nh a74nh mentioned this pull request Jun 14, 2022
Closed
@kunalspathak
Copy link
Contributor

kunalspathak commented Jun 15, 2022

cc: @danmoseley

kunalspathak
kunalspathak reviewed Jun 15, 2022
View reviewed changes
kunalspathak
kunalspathak approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

@kunalspathak kunalspathak mentioned this pull request Jun 17, 2022
Closed
danmoseley
danmoseley reviewed Jun 19, 2022
View reviewed changes
@danmoseley
Copy link
Member

danmoseley commented Jun 20, 2022

@LoopedBard3 the centos runs are failing:


2022/06/20 00:02:53][INFO] System.TypeInitializationException: A type initializer threw an exception. To determine which type, inspect the InnerException's StackTrace property.
[2022/06/20 00:02:53][INFO]  ---> EETypeRva:0x031F34D0(System.Reflection.MissingRuntimeArtifactException): This object cannot be invoked because no code was generated for it: 'BenchmarkDotNet.Jobs.EnvironmentMode.PlatformCharacteristic'.
[2022/06/20 00:02:53][INFO]    at System.Reflection.Runtime.FieldInfos.RuntimeFieldInfo.get_FieldAccessor() + 0x11e

As this is not caused by this change, nor is this coverage critical for this change, I will merge

@danmoseley danmoseley merged commit 281bdef into dotnet:main Jun 20, 2022
@danmoseley
Copy link
Member

danmoseley commented Jun 20, 2022

Thanks @a74nh

a74nh added a commit to a74nh/runtime that referenced this pull request Jun 20, 2022
@a74nh
Base64 library tests: use full encoding map
82b5bf5 
InitializeDecodableBytes is skipping the last entry in the map,
due to assuming it is an = sign.

This was spotted whilst upstreaming:
dotnet/performance#2479
@a74nh a74nh mentioned this pull request Jun 20, 2022
Merged
@a74nh a74nh mentioned this pull request Jul 13, 2022
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmoseley danmoseley danmoseley left review comments

+1 more reviewer

@kunalspathak kunalspathak kunalspathak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@a74nh @kunalspathak @danmoseley