Add more StringBuilder benchmarks.
#1999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
reviewed
Sep 13, 2021
src/benchmarks/micro/libraries/System.Text/Perf.StringBuilder.cs
Outdated
Show resolved
Hide resolved
adamsitnik
approved these changes
Sep 13, 2021
Member
adamsitnik
left a comment
adamsitnik
left a comment
There was a problem hiding this comment.
LGTM, thank you @teo-tsirpanis !
Member
|
@teo-tsirpanis if you are comfortable connecting on email, would you reach out to me at danmose - at - microsoft.com ? I have a question! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional benchmarks for the
StringBuildertype, specifically measuring appending read-only spans (on non-.NET Framework only), appending value types using string interpolation (taking advantage of the .NET 6 optimizations), and inserting primitives.related to dotnet/runtime#58907
c.c. @danmoseley