Repository navigation
Stabilize flaky TimerOrleansTest_Basic - #9934
Merged
ReubenBond merged 2 commits intoFeb 17, 2026
Merged
ReubenBond merged 2 commits into
ReubenBond merged 2 commits into
Conversation
Increase the polling timeout in TimerOrleansTest_Basic from 50 to 100 periods to tolerate scheduling variance and avoid false failures when the counter is still 8. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in TimerOrleansTest_Basic (a SlowBVT timer test) by allowing more time for the polling loop to observe the expected number of timer ticks, without changing the assertions or core intent of the test.
Changes:
- Increased the polling timeout in
TimerOrleansTest_Basicfrom 50 to 100 timer periods.
Replace stopwatch polling loops in TimerOrleansTest_Basic and TimerOrleansTest_Basic_Poco with TestingUtils.WaitUntilAsync-based waits. This restores the original timeout and avoids stale counter reads and unnecessary polling pressure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
enabled auto-merge
February 17, 2026 01:12
ReubenBond
deleted the
copilot/fix-timerorleans-basic-flaky-20260216161501
branch
February 17, 2026 02:18
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
* Stabilize TimerOrleansTest_Basic Increase the polling timeout in TimerOrleansTest_Basic from 50 to 100 periods to tolerate scheduling variance and avoid false failures when the counter is still 8. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use condition waits in timer basic tests Replace stopwatch polling loops in TimerOrleansTest_Basic and TimerOrleansTest_Basic_Poco with TestingUtils.WaitUntilAsync-based waits. This restores the original timeout and avoids stale counter reads and unnecessary polling pressure. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Microsoft Reviewers: Open in CodeFlow