Repository navigation
Fix flake in StuckGrainTest_StuckDetectionOnDeactivation - #9915
Merged
Merged
Conversation
Increase deactivation-start wait determinism in test helper by waiting up to 10 seconds and throwing a TimeoutException when deactivation does not begin, preventing false-forward assertions in flaky CI runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test (StuckGrainTest_StuckDetectionOnDeactivation) by making the WaitForDeactivationStart method more deterministic. The change increases the wait timeout from 1 second to 10 seconds and adds proper error handling by throwing a TimeoutException when deactivation doesn't start within the timeout period, rather than silently returning after the wait.
Changes:
- Modified
StuckGrain.WaitForDeactivationStartto wait up to 10 seconds (increased from 1 second) and throw aTimeoutExceptionwith a descriptive message if the grain deactivation doesn't start within that time
ReubenBond
enabled auto-merge
February 14, 2026 22:30
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Feb 14, 2026
Fix stuck grain deactivation test synchronization Increase deactivation-start wait determinism in test helper by waiting up to 10 seconds and throwing a TimeoutException when deactivation does not begin, preventing false-forward assertions in flaky CI runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Feb 14, 2026
rkargMsft
pushed a commit
to rkargMsft/orleans
that referenced
this pull request
Feb 27, 2026
Fix stuck grain deactivation test synchronization Increase deactivation-start wait determinism in test helper by waiting up to 10 seconds and throwing a TimeoutException when deactivation does not begin, preventing false-forward assertions in flaky CI runs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: make WaitForDeactivationStart deterministic by waiting up to 10 seconds and throwing TimeoutException when deactivation does not start. Validation: targeted test passed plus 20 repeated net10.0 runs and a cross-TFM run.
Microsoft Reviewers: Open in CodeFlow